Skip to content

Commit b32d1b0

Browse files
committed
refactor: rename onExternalDrag to onExternalDragOver
1 parent 2bbca0e commit b32d1b0

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

lib/HeTree.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export interface HeTreeProps<T extends Record<string, any>> extends Partial<type
6565
customDragImage?: (e: React.DragEvent<HTMLElement>, stat: Stat<T>) => void,
6666
onDragStart?: (e: React.DragEvent<HTMLElement>, stat: Stat<T>) => void,
6767
onDragOver?: (e: React.DragEvent<HTMLElement>, stat: Stat<T>, isExternal: boolean) => void,
68-
onExternalDrag?: (e: React.DragEvent<HTMLElement>) => boolean,
68+
onExternalDragOver?: (e: React.DragEvent<HTMLElement>) => boolean,
6969
onDrop?: (e: React.DragEvent<HTMLElement>, parentStat: Stat<T> | null, index: number, isExternal: boolean) => void,
7070
/**
7171
* Call on drag end in the window. If you use draggedStat in the callback, it will be undefined if onDrop alreay triggered.
@@ -315,7 +315,7 @@ export function useHeTree<T extends Record<string, any>>(
315315
props.onDragStart?.(e, stat)
316316
},
317317
onDragOver(e) {
318-
if (isExternal && !props.onExternalDrag?.(e)) {
318+
if (isExternal && !props.onExternalDragOver?.(e)) {
319319
return
320320
}
321321
// dragOpen ========================
@@ -449,7 +449,7 @@ export function useHeTree<T extends Record<string, any>>(
449449
if (isAnyNodeOver()) {
450450
return
451451
}
452-
if (isExternal && !props.onExternalDrag?.(e)) {
452+
if (isExternal && !props.onExternalDragOver?.(e)) {
453453
return
454454
}
455455
if (getDroppable(null, 0)) {
@@ -479,7 +479,7 @@ export function useHeTree<T extends Record<string, any>>(
479479
}
480480
}
481481
const onDropToRoot: React.DragEventHandler<HTMLElement> = (e) => {
482-
if (isExternal && !props.onExternalDrag?.(e)) {
482+
if (isExternal && !props.onExternalDragOver?.(e)) {
483483
return
484484
}
485485
// let customized = false
@@ -605,7 +605,7 @@ export function useHeTree<T extends Record<string, any>>(
605605
// watch props
606606
indent, placeholderId, rtl, props.rootId,
607607
// watch func
608-
...([props.canDrop, props.canDropToRoot, props.customDragImage, props.onDragStart, props.onDragOver, props.onExternalDrag, props.onDrop, props.onDragEnd, props.onChange, props.onDragOpen].map(func => isFunctionReactive && func)),
608+
...([props.canDrop, props.canDropToRoot, props.customDragImage, props.onDragStart, props.onDragOver, props.onExternalDragOver, props.onDrop, props.onDragEnd, props.onChange, props.onDragOpen].map(func => isFunctionReactive && func)),
609609
])
610610
// listen dragover on window
611611
const t2 = useMemo(() => {

src/pages/external_drag.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export default function BasePage() {
1313
renderNode: ({ id, node, open, checked, draggable }) => <div>
1414
{node.name} - {id}
1515
</div>,
16-
onExternalDrag: (e) => true,
16+
onExternalDragOver: (e) => true,
1717
onDrop: (e, parentStat, index) => {
1818
setdata(draft => {
1919
const newNode = { id: 100 + data.length, parent_id: parentStat?.id ?? null, name: "New Node" }

0 commit comments

Comments
 (0)