Skip to content

Commit 7b63c0d

Browse files
authored
Merge branch 'phpmyadmin:master' into master
2 parents cf5d9a6 + 2b712de commit 7b63c0d

File tree

5 files changed

+25
-12
lines changed

5 files changed

+25
-12
lines changed

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,15 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
1515
- Refactor `update.sh` (#408)
1616
- Enable remoteip mod for Apache (#434)
1717
- Add support for `PMA_SSL` and `PMA_SSLS` to enable SSL connection (#441)
18+
- Fixed looping through `$sockets` using the same index variable `$i` interferes with the last server id (#186)
19+
- Add support for `PMA_SSL_VERIFY` and `PMA_SSL_VERIFIES` (#448)
20+
- Add support for `PMA_SSL_CA` and `PMA_SSL_CAS` (#448)
21+
- Add support for `PMA_SSL_CERT` and `PMA_SSL_CERTS` (#448)
22+
- Add support for `PMA_SSL_KEY` and `PMA_SSL_KEYS` (#448)
23+
- Also add `PMA_SSL_DIR` to define the dir where SSL files are generated for `_BASE64` prefixed variables
24+
- Support `PMA_SSL_CA_BASE64` and `PMA_SSL_CAS_BASE64` as variables that contain the file contents (#448)
25+
- Support `PMA_SSL_KEY_BASE64` and `PMA_SSL_KEYS_BASE64` as variables that contain the file contents (#448)
26+
- Support `PMA_SSL_CERT_BASE64` and `PMA_SSL_CERTS_BASE64` as variables that contain the file contents (#448)
1827

1928
## [5.2.1] - 2023-02-08
2029

apache/config.inc.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -205,9 +205,10 @@
205205
$cfg['Servers'][$i]['compress'] = false;
206206
$cfg['Servers'][$i]['AllowNoPassword'] = true;
207207
}
208-
for ($i = 1; isset($sockets[$i - 1]); $i++) {
209-
$cfg['Servers'][$i]['socket'] = $sockets[$i - 1];
210-
$cfg['Servers'][$i]['host'] = 'localhost';
208+
// Avoid overwriting the last server id $i, use another variable name
209+
for ($socketHostId = 1; isset($sockets[$socketHostId - 1]); $socketHostId++) {
210+
$cfg['Servers'][$socketHostId]['socket'] = $sockets[$socketHostId - 1];
211+
$cfg['Servers'][$socketHostId]['host'] = 'localhost';
211212
}
212213
/*
213214
* Revert back to last configured server to make

config.inc.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -205,9 +205,10 @@
205205
$cfg['Servers'][$i]['compress'] = false;
206206
$cfg['Servers'][$i]['AllowNoPassword'] = true;
207207
}
208-
for ($i = 1; isset($sockets[$i - 1]); $i++) {
209-
$cfg['Servers'][$i]['socket'] = $sockets[$i - 1];
210-
$cfg['Servers'][$i]['host'] = 'localhost';
208+
// Avoid overwriting the last server id $i, use another variable name
209+
for ($socketHostId = 1; isset($sockets[$socketHostId - 1]); $socketHostId++) {
210+
$cfg['Servers'][$socketHostId]['socket'] = $sockets[$socketHostId - 1];
211+
$cfg['Servers'][$socketHostId]['host'] = 'localhost';
211212
}
212213
/*
213214
* Revert back to last configured server to make

fpm-alpine/config.inc.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -205,9 +205,10 @@
205205
$cfg['Servers'][$i]['compress'] = false;
206206
$cfg['Servers'][$i]['AllowNoPassword'] = true;
207207
}
208-
for ($i = 1; isset($sockets[$i - 1]); $i++) {
209-
$cfg['Servers'][$i]['socket'] = $sockets[$i - 1];
210-
$cfg['Servers'][$i]['host'] = 'localhost';
208+
// Avoid overwriting the last server id $i, use another variable name
209+
for ($socketHostId = 1; isset($sockets[$socketHostId - 1]); $socketHostId++) {
210+
$cfg['Servers'][$socketHostId]['socket'] = $sockets[$socketHostId - 1];
211+
$cfg['Servers'][$socketHostId]['host'] = 'localhost';
211212
}
212213
/*
213214
* Revert back to last configured server to make

fpm/config.inc.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -205,9 +205,10 @@
205205
$cfg['Servers'][$i]['compress'] = false;
206206
$cfg['Servers'][$i]['AllowNoPassword'] = true;
207207
}
208-
for ($i = 1; isset($sockets[$i - 1]); $i++) {
209-
$cfg['Servers'][$i]['socket'] = $sockets[$i - 1];
210-
$cfg['Servers'][$i]['host'] = 'localhost';
208+
// Avoid overwriting the last server id $i, use another variable name
209+
for ($socketHostId = 1; isset($sockets[$socketHostId - 1]); $socketHostId++) {
210+
$cfg['Servers'][$socketHostId]['socket'] = $sockets[$socketHostId - 1];
211+
$cfg['Servers'][$socketHostId]['host'] = 'localhost';
211212
}
212213
/*
213214
* Revert back to last configured server to make

0 commit comments

Comments
 (0)