Revert the deprecation of passing string to Context::setMode

This is useful when passing the sql_mode result directly from MySQL/MariaDB.

Signed-off-by: Maurício Meneghini Fauth <[email protected]>

Author: MauricioFauth

CHANGELOG.md

@@ -5,7 +5,6 @@
 * Add missing return types annotations
 * Improve the WITH statements parser (#363)
 * Add support for passing `Context::SQL_MODE*` constants to `Context::setMode` method
-* Deprecate passing strings to the `Context::setMode` method
 
 ## [5.5.0] - 2021-12-08
 

src/Context.php

@@ -672,16 +672,13 @@ public static function getMode(): int
     /**
      * Sets the SQL mode.
      *
-     * @param int $mode
-     * @psalm-param 0|positive-int $mode
+     * @param int|string $mode
      *
      * @return void
      */
     public static function setMode($mode = self::SQL_MODE_NONE)
     {
-        /** @var int|string $mode Used to set the old type to $mode for static analysis tools. */
-        $mode = $mode;
-        if (is_int($mode) && $mode >= 1) {
+        if (is_int($mode)) {
             static::$MODE = $mode;
 
             return;

tests/Lexer/ContextTest.php

@@ -128,10 +128,6 @@ public function testLoadError(): void
      */
     public function testMode($mode, int $expected): void
     {
-        /**
-         * @psalm-suppress ArgumentTypeCoercion
-         * @phpstan-ignore-next-line
-         */
         Context::setMode($mode);
         $this->assertSame($expected, Context::getMode());
     }
@@ -143,7 +139,6 @@ public function testMode($mode, int $expected): void
     public function providerForTestMode(): array
     {
         return [
-            [-1, Context::SQL_MODE_NONE],
             [0, Context::SQL_MODE_NONE],
             [1, 1],
             ['', Context::SQL_MODE_NONE],
@@ -202,15 +197,8 @@ public function testModeWithCombinedModes(): void
         $this->assertSame(Context::SQL_MODE_NONE, Context::getMode());
     }
 
-    /**
-     * BC tests
-     */
     public function testModeWithString(): void
     {
-        /**
-         * @psalm-suppress InvalidScalarArgument
-         * @phpstan-ignore-next-line
-         */
         Context::setMode('REAL_AS_FLOAT,ANSI_QUOTES,IGNORE_SPACE');
         $this->assertSame(
             Context::SQL_MODE_REAL_AS_FLOAT | Context::SQL_MODE_ANSI_QUOTES | Context::SQL_MODE_IGNORE_SPACE,
@@ -221,17 +209,9 @@ public function testModeWithString(): void
         $this->assertFalse(Context::hasMode(Context::SQL_MODE_REAL_AS_FLOAT | Context::SQL_MODE_ALLOW_INVALID_DATES));
         $this->assertFalse(Context::hasMode(Context::SQL_MODE_ALLOW_INVALID_DATES));
 
-        /**
-         * @psalm-suppress InvalidScalarArgument
-         * @phpstan-ignore-next-line
-         */
         Context::setMode('TRADITIONAL');
         $this->assertSame(Context::SQL_MODE_TRADITIONAL, Context::getMode());
 
-        /**
-         * @psalm-suppress InvalidScalarArgument
-         * @phpstan-ignore-next-line
-         */
         Context::setMode('');
         $this->assertSame(Context::SQL_MODE_NONE, Context::getMode());
     }