Merge pull request #482 from kamil-tekiela/Drop-$options

Drop $options param from Component::build

Author: MauricioFauth

src/Component.php

@@ -32,8 +32,7 @@ public static function parse(Parser $parser, TokensList $list, array $options =
      *
      * In other words, this function represents the inverse function of {@see Component::parse()}.
      *
-     * @param mixed                $component the component to be built
-     * @param array<string, mixed> $options   parameters for building
+     * @param mixed $component the component to be built
      */
-    public static function build($component, array $options = []): string;
+    public static function build($component): string;
 }

src/Components/AlterOperation.php

@@ -520,10 +520,9 @@ public static function parse(Parser $parser, TokensList $list, array $options =
     }
 
     /**
-     * @param AlterOperation       $component the component to be built
-     * @param array<string, mixed> $options   parameters for building
+     * @param AlterOperation $component the component to be built
      */
-    public static function build($component, array $options = []): string
+    public static function build($component): string
     {
         // Specific case of RENAME COLUMN that insert the field between 2 options.
         $afterFieldsOptions = new OptionsArray();

src/Components/Array2d.php

@@ -112,10 +112,9 @@ public static function parse(Parser $parser, TokensList $list, array $options =
     }
 
     /**
-     * @param ArrayObj[]           $component the component to be built
-     * @param array<string, mixed> $options   parameters for building
+     * @param ArrayObj[] $component the component to be built
      */
-    public static function build($component, array $options = []): string
+    public static function build($component): string
     {
         return ArrayObj::build($component);
     }

src/Components/ArrayObj.php

@@ -159,10 +159,9 @@ public static function parse(Parser $parser, TokensList $list, array $options =
     }
 
     /**
-     * @param ArrayObj|ArrayObj[]  $component the component to be built
-     * @param array<string, mixed> $options   parameters for building
+     * @param ArrayObj|ArrayObj[] $component the component to be built
      */
-    public static function build($component, array $options = []): string
+    public static function build($component): string
     {
         if (is_array($component)) {
             return implode(', ', $component);

src/Components/CaseExpression.php

@@ -253,10 +253,9 @@ public static function parse(Parser $parser, TokensList $list, array $options =
     }
 
     /**
-     * @param CaseExpression       $component the component to be built
-     * @param array<string, mixed> $options   parameters for building
+     * @param CaseExpression $component the component to be built
      */
-    public static function build($component, array $options = []): string
+    public static function build($component): string
     {
         $ret = 'CASE ';
         if (isset($component->value)) {

src/Components/Condition.php

@@ -221,10 +221,9 @@ public static function parse(Parser $parser, TokensList $list, array $options =
     }
 
     /**
-     * @param Condition[]          $component the component to be built
-     * @param array<string, mixed> $options   parameters for building
+     * @param Condition[] $component the component to be built
      */
-    public static function build($component, array $options = []): string
+    public static function build($component): string
     {
         if (is_array($component)) {
             return implode(' ', $component);

src/Components/CreateDefinition.php

@@ -319,9 +319,8 @@ public static function parse(Parser $parser, TokensList $list, array $options =
 
     /**
      * @param CreateDefinition|CreateDefinition[] $component the component to be built
-     * @param array<string, mixed>                $options   parameters for building
      */
-    public static function build($component, array $options = []): string
+    public static function build($component): string
     {
         if (is_array($component)) {
             return "(\n  " . implode(",\n  ", $component) . "\n)";
@@ -338,10 +337,8 @@ public static function build($component, array $options = []): string
         }
 
         if (! empty($component->type)) {
-            $tmp .= DataType::build(
-                $component->type,
-                ['lowercase' => true]
-            ) . ' ';
+            $component->type->lowercase = true;
+            $tmp .= DataType::build($component->type) . ' ';
         }
 
         if (! empty($component->key)) {

src/Components/DataType.php

@@ -72,6 +72,8 @@ final class DataType implements Component
      */
     public $options;
 
+    public bool $lowercase = false;
+
     /**
      * @param string         $name       the name of this data type
      * @param int[]|string[] $parameters the parameters (size or possible values)
@@ -153,13 +155,11 @@ public static function parse(Parser $parser, TokensList $list, array $options =
     }
 
     /**
-     * @param DataType             $component the component to be built
-     * @param array<string, mixed> $options   parameters for building
+     * @param DataType $component the component to be built
      */
-    public static function build($component, array $options = []): string
+    public static function build($component): string
     {
-        $name = empty($options['lowercase']) ?
-            $component->name : strtolower($component->name);
+        $name = $component->lowercase ? strtolower($component->name) : $component->name;
 
         $parameters = '';
         if ($component->parameters !== []) {

src/Components/Expression.php

@@ -448,9 +448,8 @@ public static function parse(Parser $parser, TokensList $list, array $options =
 
     /**
      * @param Expression|Expression[] $component the component to be built
-     * @param array<string, mixed>    $options   parameters for building
      */
-    public static function build($component, array $options = []): string
+    public static function build($component): string
     {
         if (is_array($component)) {
             return implode(', ', $component);

src/Components/ExpressionArray.php

@@ -117,10 +117,9 @@ public static function parse(Parser $parser, TokensList $list, array $options =
     }
 
     /**
-     * @param Expression[]         $component the component to be built
-     * @param array<string, mixed> $options   parameters for building
+     * @param Expression[] $component the component to be built
      */
-    public static function build($component, array $options = []): string
+    public static function build($component): string
     {
         $ret = [];
         foreach ($component as $frag) {