Fix undefined array key in WithStatement

The CTE name must be a valid identifier.

Signed-off-by: Maurício Meneghini Fauth <[email protected]>

Author: MauricioFauth

src/Statements/WithStatement.php

@@ -16,6 +16,7 @@
 
 use function array_slice;
 use function count;
+use function preg_match;
 
 /**
  * `WITH` statement.
@@ -114,7 +115,7 @@ public function parse(Parser $parser, TokensList $list)
             }
 
             if ($state === 0) {
-                if ($token->type !== Token::TYPE_NONE) {
+                if ($token->type !== Token::TYPE_NONE || ! preg_match('/^[a-zA-Z0-9_$]+$/', $token->token)) {
                     $parser->error('The name of the CTE was expected.', $token);
                     break;
                 }

tests/Misc/BugsTest.php

@@ -23,6 +23,7 @@ public function bugProvider(): array
     {
         return [
             ['bugs/fuzz1'],
+            ['bugs/fuzz2'],
             ['bugs/gh9'],
             ['bugs/gh14'],
             ['bugs/gh16'],

tests/data/bugs/fuzz2.in

@@ -0,0 +1 @@
+WITH](

tests/data/bugs/fuzz2.out

@@ -0,0 +1,111 @@
+{
+    "query": "WITH](",
+    "lexer": {
+        "@type": "PhpMyAdmin\\SqlParser\\Lexer",
+        "str": "WITH](",
+        "len": 6,
+        "last": 6,
+        "list": {
+            "@type": "PhpMyAdmin\\SqlParser\\TokensList",
+            "tokens": [
+                {
+                    "@type": "PhpMyAdmin\\SqlParser\\Token",
+                    "token": "WITH",
+                    "value": "WITH",
+                    "keyword": "WITH",
+                    "type": 1,
+                    "flags": 3,
+                    "position": 0
+                },
+                {
+                    "@type": "PhpMyAdmin\\SqlParser\\Token",
+                    "token": "]",
+                    "value": "]",
+                    "keyword": null,
+                    "type": 0,
+                    "flags": 0,
+                    "position": 4
+                },
+                {
+                    "@type": "PhpMyAdmin\\SqlParser\\Token",
+                    "token": "(",
+                    "value": "(",
+                    "keyword": null,
+                    "type": 2,
+                    "flags": 16,
+                    "position": 5
+                },
+                {
+                    "@type": "PhpMyAdmin\\SqlParser\\Token",
+                    "token": null,
+                    "value": null,
+                    "keyword": null,
+                    "type": 9,
+                    "flags": 0,
+                    "position": null
+                }
+            ],
+            "count": 4,
+            "idx": 4
+        },
+        "delimiter": ";",
+        "delimiterLen": 1,
+        "strict": false,
+        "errors": []
+    },
+    "parser": {
+        "@type": "PhpMyAdmin\\SqlParser\\Parser",
+        "list": {
+            "@type": "@1"
+        },
+        "statements": [
+            {
+                "@type": "PhpMyAdmin\\SqlParser\\Statements\\WithStatement",
+                "withers": [],
+                "cteStatementParser": null,
+                "options": {
+                    "@type": "PhpMyAdmin\\SqlParser\\Components\\OptionsArray",
+                    "options": []
+                },
+                "first": 0,
+                "last": 0
+            }
+        ],
+        "brackets": 1,
+        "strict": false,
+        "errors": []
+    },
+    "errors": {
+        "lexer": [
+            [
+                "Unexpected character.",
+                "]",
+                4,
+                0
+            ]
+        ],
+        "parser": [
+            [
+                "The name of the CTE was expected.",
+                {
+                    "@type": "@3"
+                },
+                0
+            ],
+            [
+                "Unexpected end of the WITH CTE.",
+                {
+                    "@type": "@3"
+                },
+                0
+            ],
+            [
+                "Unexpected beginning of statement.",
+                {
+                    "@type": "@3"
+                },
+                0
+            ]
+        ]
+    }
+}