Skip to content

Conversation

@MoonE
Copy link
Contributor

@MoonE MoonE commented Jul 30, 2023

See #488

Signed-off-by: Maximilian Krög <[email protected]>
@MoonE MoonE changed the base branch from master to 5.8.x July 30, 2023 11:50
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@williamdes williamdes added this to the 5.9.0 milestone Jul 30, 2023
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.32% ⚠️

Comparison is base (9838a1c) 96.93% compared to head (4751563) 96.61%.
Report is 10 commits behind head on 5.8.x.

Additional details and impacted files
@@             Coverage Diff              @@
##              5.8.x     #489      +/-   ##
============================================
- Coverage     96.93%   96.61%   -0.32%     
+ Complexity     2233     2173      -60     
============================================
  Files            69       66       -3     
  Lines          5150     5054      -96     
============================================
- Hits           4992     4883     -109     
- Misses          158      171      +13     
Files Changed Coverage Δ
src/Components/Expression.php 100.00% <100.00%> (ø)
src/Components/SetOperation.php 100.00% <100.00%> (ø)

... and 64 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@williamdes williamdes changed the title Reset sql mode after context tests QA Reset sql mode after context tests Aug 12, 2023
@williamdes williamdes self-assigned this Aug 12, 2023
@williamdes williamdes merged commit 18da8b1 into phpmyadmin:5.8.x Aug 12, 2023
@MoonE MoonE deleted the context-test-qa branch August 12, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants