Implement NonFalseyNonEmptyStringMutator

Author: staabm

src/Infection/IsSuperTypeOfCalleeAndArgumentMutator.php

@@ -5,8 +5,8 @@
 use Infection\Mutator\Definition;
 use Infection\Mutator\Mutator;
 use Infection\Mutator\MutatorCategory;
+use LogicException;
 use PhpParser\Node;
-use RuntimeException;
 use function count;
 use function in_array;
 
@@ -83,7 +83,7 @@ public function mutate(Node $node): iterable
 	{
 		$args = $node->getArgs();
 		if (count($args) !== 1) {
-			throw new RuntimeException();
+			throw new LogicException();
 		}
 
 		yield new Node\Expr\MethodCall(

src/Infection/NonFalseyNonEmptyStringMutator.php

@@ -0,0 +1,74 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Infection;
+
+use Infection\Mutator\Definition;
+use Infection\Mutator\Mutator;
+use Infection\Mutator\MutatorCategory;
+use LogicException;
+use PhpParser\Node;
+use function count;
+use function in_array;
+
+/**
+ * @implements Mutator<Node\Expr\MethodCall>
+ */
+final class NonFalseyNonEmptyStringMutator implements Mutator
+{
+
+	public static function getDefinition(): Definition
+	{
+		return new Definition(
+			<<<'TXT'
+				Replaces boolean Type->isNonFalseyString() with Type->isNonEmptyString().
+				TXT
+			,
+			MutatorCategory::ORTHOGONAL_REPLACEMENT,
+			null,
+			<<<'DIFF'
+				- $type->isNonFalseyString()->yes();
+				+ $type->isNonEmptyString()->yes();
+			DIFF,
+		);
+	}
+
+	public function getName(): string
+	{
+		return self::class;
+	}
+
+	public function canMutate(Node $node): bool
+	{
+		if (!$node instanceof Node\Expr\MethodCall) {
+			return false;
+		}
+
+		if (!$node->name instanceof Node\Identifier) {
+			return false;
+		}
+
+		if (!in_array($node->name->name, ['isNonEmptyString', 'isNonFalseyString'], true)) {
+			return false;
+		}
+
+		if (count($node->getArgs()) !== 0) {
+			return false;
+		}
+
+		return true;
+	}
+
+	public function mutate(Node $node): iterable
+	{
+		if (!$node->name instanceof Node\Identifier) {
+			throw new LogicException();
+		}
+
+		if ($node->name->name === 'isNonEmptyString') {
+			yield new Node\Expr\MethodCall($node->var, 'isNonFalseyString');
+		} else {
+			yield new Node\Expr\MethodCall($node->var, 'isNonEmptyString');
+		}
+	}
+
+}

tests/Infection/NonFalseyNonEmptyStringMutatorTest.php

@@ -0,0 +1,72 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Infection;
+
+use Infection\Testing\BaseMutatorTestCase;
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DataProvider;
+
+#[CoversClass(NonFalseyNonEmptyStringMutator::class)]
+final class NonFalseyNonEmptyStringMutatorTest extends BaseMutatorTestCase
+{
+
+	/**
+	 * @param string|string[] $expected
+	 */
+	#[DataProvider('mutationsProvider')]
+	public function testMutator(string $input, $expected = []): void
+	{
+		$this->assertMutatesInput($input, $expected);
+	}
+
+	/**
+	 * @return iterable<string, array{0: string, 1?: string}>
+	 */
+	public static function mutationsProvider(): iterable
+	{
+		yield 'It mutates isNonEmptyString()' => [
+			<<<'PHP'
+				<?php
+
+				$type->isNonEmptyString()->yes();
+				PHP
+,
+			<<<'PHP'
+				<?php
+
+				$type->isNonFalseyString()->yes();
+				PHP
+,
+		];
+
+		yield 'It mutates isNonFalseyString()' => [
+			<<<'PHP'
+				<?php
+
+				$type->isNonFalseyString()->yes();
+				PHP
+,
+			<<<'PHP'
+				<?php
+
+				$type->isNonEmptyString()->yes();
+				PHP
+,
+		];
+
+		yield 'skip with arguments' => [
+			<<<'PHP'
+				<?php
+
+				$a->isNonFalseyString($b);
+				PHP
+,
+		];
+	}
+
+	protected function getTestedMutatorClassName(): string
+	{
+		return NonFalseyNonEmptyStringMutator::class;
+	}
+
+}