Optimization - no need to append setParameter() calls

Author: ondrejmirtes

src/Type/Doctrine/QueryBuilder/QueryBuilderMethodDynamicReturnTypeExtension.php

@@ -3,6 +3,7 @@
 namespace PHPStan\Type\Doctrine\QueryBuilder;
 
 use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Identifier;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Reflection\ParametersAcceptorSelector;
@@ -46,11 +47,20 @@ public function getTypeFromMethodCall(
 	): Type
 	{
 		$calledOnType = $scope->getType($methodCall->var);
+		if (!$methodCall->name instanceof Identifier) {
+			return $calledOnType;
+		}
+		$lowerMethodName = strtolower($methodCall->name->toString());
+		if (in_array($lowerMethodName, [
+			'setparameter',
+			'setparameters',
+		], true)) {
+			return $calledOnType;
+		}
+
 		$queryBuilderTypes = DoctrineTypeUtils::getQueryBuilderTypes($calledOnType);
 		if (count($queryBuilderTypes) === 0) {
-			return ParametersAcceptorSelector::selectSingle(
-				$methodReflection->getVariants()
-			)->getReturnType();
+			return $calledOnType;
 		}
 
 		$resultTypes = [];

src/Type/Doctrine/QueryBuilder/QueryBuilderTypeSpecifyingExtension.php

@@ -3,6 +3,7 @@
 namespace PHPStan\Type\Doctrine\QueryBuilder;
 
 use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Identifier;
 use PHPStan\Analyser\Scope;
 use PHPStan\Analyser\SpecifiedTypes;
 use PHPStan\Analyser\TypeSpecifier;
@@ -50,6 +51,17 @@ public function specifyTypes(MethodReflection $methodReflection, MethodCall $nod
 		if (!$scope->isInFirstLevelStatement()) {
 			return new SpecifiedTypes([]);
 		}
+		if (!$node->name instanceof Identifier) {
+			return new SpecifiedTypes([]);
+		}
+
+		$lowerMethodName = strtolower($node->name->toString());
+		if (in_array($lowerMethodName, [
+			'setparameter',
+			'setparameters',
+		], true)) {
+			return new SpecifiedTypes([]);
+		}
 
 		$returnType = ParametersAcceptorSelector::selectFromArgs(
 			$scope,