Generalizing extensions to accept parameters through constructor

Author: ondrejmirtes

extension.neon

@@ -3,16 +3,23 @@ services:
 		class: PHPStan\Mockery\Reflection\StubMethodsClassReflectionExtension
 		tags:
 			- phpstan.broker.methodsClassReflectionExtension
+		arguments:
+			stubInterfaceName: PHPStan\Mockery\Type\Allows
 
 	-
 		class: PHPStan\Mockery\Type\StubDynamicReturnTypeExtension
 		tags:
 			- phpstan.broker.dynamicMethodReturnTypeExtension
+		arguments:
+			stubInterfaceName: PHPStan\Mockery\Type\Allows
+			stubMethodName: allows
 
 	-
 		class: PHPStan\Mockery\Type\ExpectationAfterStubDynamicReturnTypeExtension
 		tags:
 			- phpstan.broker.dynamicMethodReturnTypeExtension
+		arguments:
+			stubInterfaceName: PHPStan\Mockery\Type\Allows
 
 	-
 		class: PHPStan\Mockery\Type\MockDynamicReturnTypeExtension

src/Mockery/Reflection/StubMethodsClassReflectionExtension.php

@@ -2,17 +2,24 @@
 
 namespace PHPStan\Mockery\Reflection;
 
-use PHPStan\Mockery\Type\Allows;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Reflection\MethodsClassReflectionExtension;
 
 class StubMethodsClassReflectionExtension implements MethodsClassReflectionExtension
 {
 
+	/** @var string */
+	private $stubInterfaceName;
+
+	public function __construct(string $stubInterfaceName)
+	{
+		$this->stubInterfaceName = $stubInterfaceName;
+	}
+
 	public function hasMethod(ClassReflection $classReflection, string $methodName): bool
 	{
-		return $classReflection->getName() === Allows::class;
+		return $classReflection->getName() === $this->stubInterfaceName;
 	}
 
 	public function getMethod(ClassReflection $classReflection, string $methodName): MethodReflection

src/Mockery/Type/ExpectationAfterStubDynamicReturnTypeExtension.php

@@ -12,9 +12,17 @@
 class ExpectationAfterStubDynamicReturnTypeExtension implements DynamicMethodReturnTypeExtension
 {
 
+	/** @var string */
+	private $stubInterfaceName;
+
+	public function __construct(string $stubInterfaceName)
+	{
+		$this->stubInterfaceName = $stubInterfaceName;
+	}
+
 	public function getClass(): string
 	{
-		return Allows::class;
+		return $this->stubInterfaceName;
 	}
 
 	public function isMethodSupported(MethodReflection $methodReflection): bool

src/Mockery/Type/StubDynamicReturnTypeExtension.php

@@ -16,14 +16,26 @@
 class StubDynamicReturnTypeExtension implements DynamicMethodReturnTypeExtension
 {
 
+	/** @var string */
+	private $stubInterfaceName;
+
+	/** @var string */
+	private $stubMethodName;
+
+	public function __construct(string $stubInterfaceName, string $stubMethodName)
+	{
+		$this->stubInterfaceName = $stubInterfaceName;
+		$this->stubMethodName = $stubMethodName;
+	}
+
 	public function getClass(): string
 	{
 		return 'Mockery\\MockInterface';
 	}
 
 	public function isMethodSupported(MethodReflection $methodReflection): bool
 	{
-		return $methodReflection->getName() === 'allows';
+		return $methodReflection->getName() === $this->stubMethodName;
 	}
 
 	public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): Type
@@ -40,7 +52,7 @@ public function getTypeFromMethodCall(MethodReflection $methodReflection, Method
 
 		return TypeCombinator::intersect(
 			new StubObjectType($mockedType->getClassName()),
-			new ObjectType(Allows::class)
+			new ObjectType($this->stubInterfaceName)
 		);
 	}