Fixed compatibility with PHPStan 0.12

Author: ondrejmirtes

build.xml

@@ -88,7 +88,7 @@
 		>
 			<arg value="analyse"/>
 			<arg value="-l"/>
-			<arg value="7"/>
+			<arg value="8"/>
 			<arg value="-c"/>
 			<arg path="phpstan.neon"/>
 			<arg path="src"/>

phpcs.xml

@@ -23,7 +23,10 @@
 				@dataProvider,
 				@requires
 			"/>
+			<property name="enableObjectTypeHint" value="false"/>
 		</properties>
+		<exclude name="SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingTraversableParameterTypeHintSpecification"/>
+		<exclude name="SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingTraversableReturnTypeHintSpecification"/>
 	</rule>
 	<rule ref="SlevomatCodingStandard.ControlStructures.AssignmentInCondition"/>
 	<rule ref="SlevomatCodingStandard.ControlStructures.DisallowEqualOperators"/>

phpstan.neon

@@ -9,9 +9,8 @@ includes:
 
 parameters:
 	excludes_analyse:
-		- %rootDir%/../../../tests/*/data/*
-		- %rootDir%/../../../tests/NetteObjectChild.php
+		- tests/*/data/*
+		- tests/NetteObjectChild.php
 
 	ignoreErrors:
-		- '~^Parameter \#1 \$node \(.*\) of method .*Rule::processNode\(\) should be contravariant with parameter \$node \(PhpParser\\Node\) of method PHPStan\\Rules\\Rule::processNode\(\)$~'
 		- '~^Variable property access on PhpParser\\Node\.$~'

src/Reflection/Nette/HtmlMethodReflection.php

@@ -50,6 +50,7 @@ public function getVariants(): array
 	{
 		return [
 			new FunctionVariant(
+				TemplateTypeMap::createEmpty(),
 				TemplateTypeMap::createEmpty(),
 				[],
 				true,
@@ -93,9 +94,19 @@ public function isInternal(): TrinaryLogic
 		return TrinaryLogic::createNo();
 	}
 
-	public function getThrowType(): ?Type
+	public function getThrowType(): Type
 	{
 		return new VoidType();
 	}
 
+	public function getDocComment(): ?string
+	{
+		return null;
+	}
+
+	public function hasSideEffects(): \PHPStan\TrinaryLogic
+	{
+		return TrinaryLogic::createYes();
+	}
+
 }

src/Reflection/Nette/HtmlPropertyReflection.php

@@ -14,9 +14,13 @@ class HtmlPropertyReflection implements PropertyReflection
 	/** @var \PHPStan\Reflection\ClassReflection */
 	private $declaringClass;
 
+	/** @var Type */
+	private $type;
+
 	public function __construct(ClassReflection $declaringClass)
 	{
 		$this->declaringClass = $declaringClass;
+		$this->type = new MixedType();
 	}
 
 	public function getDeclaringClass(): ClassReflection
@@ -39,11 +43,6 @@ public function isPublic(): bool
 		return true;
 	}
 
-	public function getType(): Type
-	{
-		return new MixedType();
-	}
-
 	public function isReadable(): bool
 	{
 		return true;
@@ -69,4 +68,24 @@ public function isInternal(): TrinaryLogic
 		return TrinaryLogic::createNo();
 	}
 
+	public function getDocComment(): ?string
+	{
+		return null;
+	}
+
+	public function getReadableType(): \PHPStan\Type\Type
+	{
+		return $this->type;
+	}
+
+	public function getWritableType(): \PHPStan\Type\Type
+	{
+		return $this->type;
+	}
+
+	public function canChangeTypeAfterAssignment(): bool
+	{
+		return true;
+	}
+
 }

src/Reflection/Nette/NetteObjectClassReflectionExtension.php

@@ -66,7 +66,7 @@ public function getMethod(ClassReflection $classReflection, string $methodName):
 	}
 
 	/**
-	 * @param \ReflectionClass $class
+	 * @param \ReflectionClass<object> $class
 	 * @return string[]
 	 */
 	private function getTraitNames(\ReflectionClass $class): array
@@ -80,6 +80,10 @@ private function getTraitNames(\ReflectionClass $class): array
 		return $traitNames;
 	}
 
+	/**
+	 * @param \ReflectionClass<object> $class
+	 * @return bool
+	 */
 	private function inheritsFromNetteObject(\ReflectionClass $class): bool
 	{
 		$class = $class->getParentClass();

src/Reflection/Nette/NetteObjectEventListenerMethodReflection.php

@@ -53,6 +53,7 @@ public function getVariants(): array
 	{
 		return [
 			new FunctionVariant(
+				TemplateTypeMap::createEmpty(),
 				TemplateTypeMap::createEmpty(),
 				[],
 				true,
@@ -96,4 +97,14 @@ public function getThrowType(): ?Type
 		return null;
 	}
 
+	public function getDocComment(): ?string
+	{
+		return null;
+	}
+
+	public function hasSideEffects(): \PHPStan\TrinaryLogic
+	{
+		return TrinaryLogic::createYes();
+	}
+
 }

src/Reflection/Nette/NetteObjectPropertyReflection.php

@@ -42,11 +42,6 @@ public function isPublic(): bool
 		return true;
 	}
 
-	public function getType(): Type
-	{
-		return $this->type;
-	}
-
 	public function isReadable(): bool
 	{
 		return true;
@@ -72,4 +67,24 @@ public function isInternal(): TrinaryLogic
 		return TrinaryLogic::createNo();
 	}
 
+	public function getDocComment(): ?string
+	{
+		return null;
+	}
+
+	public function getReadableType(): \PHPStan\Type\Type
+	{
+		return $this->type;
+	}
+
+	public function getWritableType(): \PHPStan\Type\Type
+	{
+		return $this->type;
+	}
+
+	public function canChangeTypeAfterAssignment(): bool
+	{
+		return true;
+	}
+
 }

src/Rule/Nette/DoNotExtendNetteObjectRule.php

@@ -7,6 +7,9 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Broker\Broker;
 
+/**
+ * @implements \PHPStan\Rules\Rule<Class_>
+ */
 class DoNotExtendNetteObjectRule implements \PHPStan\Rules\Rule
 {
 
@@ -23,11 +26,6 @@ public function getNodeType(): string
 		return Class_::class;
 	}
 
-	/**
-	 * @param \PhpParser\Node\Stmt\Class_ $node
-	 * @param \PHPStan\Analyser\Scope $scope
-	 * @return string[] errors
-	 */
 	public function processNode(Node $node, Scope $scope): array
 	{
 		if (!isset($node->namespacedName)) {

src/Rule/Nette/RethrowExceptionRule.php

@@ -9,6 +9,9 @@
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\TypeCombinator;
 
+/**
+ * @implements \PHPStan\Rules\Rule<TryCatch>
+ */
 class RethrowExceptionRule implements \PHPStan\Rules\Rule
 {
 
@@ -28,11 +31,6 @@ public function getNodeType(): string
 		return TryCatch::class;
 	}
 
-	/**
-	 * @param \PhpParser\Node\Stmt\TryCatch $node
-	 * @param \PHPStan\Analyser\Scope $scope
-	 * @return string[] errors
-	 */
 	public function processNode(Node $node, Scope $scope): array
 	{
 		$hasGeneralCatch = false;