Build and tests

ondrejmirtes · ondrejmirtes · commit 9ac6b537d0f6 · 2016-07-17T16:24:38.000+02:00
diff --git a/.gitattributes b/.gitattributes
@@ -0,0 +1 @@
+/tests export-ignore
diff --git a/build.xml b/build.xml
@@ -0,0 +1,101 @@
+<?xml version="1.0" encoding="utf-8"?>
+<project name="PHPStan Nette class reflection extension" default="check">
+
+	<target name="check" depends="
+		composer,
+		lint,
+		cs,
+		tests,
+		phpstan
+	"/>
+
+	<target name="composer">
+		<exec
+				executable="composer"
+				logoutput="true"
+				passthru="true"
+				checkreturn="true"
+		>
+			<arg value="install"/>
+		</exec>
+	</target>
+
+	<target name="lint">
+		<exec
+				executable="vendor/bin/parallel-lint"
+				logoutput="true"
+				passthru="true"
+				checkreturn="true"
+		>
+			<arg value="--exclude"/>
+			<arg path="tests/PHPStan/Analyser/data"/>
+			<arg path="src" />
+			<arg path="tests" />
+		</exec>
+	</target>
+
+	<target name="cs">
+		<exec
+				executable="vendor/bin/phpcs"
+				logoutput="true"
+				passthru="true"
+				checkreturn="true"
+		>
+			<arg value="--standard=ruleset.xml"/>
+			<arg value="--extensions=php"/>
+			<arg value="--encoding=utf-8"/>
+			<arg value="--tab-width=4"/>
+			<arg value="--ignore=tests/*/data"/>
+			<arg value="-sp"/>
+			<arg path="src"/>
+			<arg path="tests"/>
+		</exec>
+	</target>
+
+	<target name="cs-fix">
+		<exec
+				executable="vendor/bin/phpcbf"
+				logoutput="true"
+				passthru="true"
+				checkreturn="true"
+		>
+			<arg value="--standard=ruleset.xml"/>
+			<arg value="--extensions=php"/>
+			<arg value="--encoding=utf-8"/>
+			<arg value="--tab-width=4"/>
+			<arg value="--ignore=tests/*/data"/>
+			<arg value="-sp"/>
+			<arg path="src"/>
+			<arg path="tests"/>
+		</exec>
+	</target>
+
+	<target name="tests">
+		<exec
+				executable="vendor/bin/phpunit"
+				logoutput="true"
+				passthru="true"
+				checkreturn="true"
+		>
+			<arg value="-c"/>
+			<arg value="tests/phpunit.xml"/>
+			<arg path="tests"/>
+		</exec>
+	</target>
+
+	<target name="phpstan">
+		<exec
+				executable="vendor/bin/phpstan"
+				logoutput="true"
+				passthru="true"
+				checkreturn="true"
+		>
+			<arg value="analyse"/>
+			<arg value="-c"/>
+			<arg path="phpstan.neon"/>
+			<arg path="src"/>
+			<arg path="tests"/>
+		</exec>
+	</target>
+
+</project>
diff --git a/composer.json b/composer.json
@@ -6,12 +6,21 @@
 	"prefer-stable": true,
 	"require": {
 		"php": "~7.0",
-		"phpstan/phpstan": "dev-dev#19c97e3f31",
+		"phpstan/phpstan": "dev-dev#a5db1f45ed",
 		"nette/utils": "^2.3.0"
 	},
+	"require-dev": {
+		"consistence/coding-standard": "~0.11.0",
+		"phing/phing": "^2.13.0",
+		"phpunit/phpunit": "^5.3",
+		"slevomat/coding-standard": "dev-php7#961090ac32"
+	},
 	"autoload": {
 		"psr-4": {
   			"PHPStan\\": "src/"
 		}
+	},
+	"autoload-dev": {
+		"classmap": ["tests/"]
 	}
 }
diff --git a/phpstan.neon b/phpstan.neon
@@ -0,0 +1,3 @@
+parameters:
+	ignoreErrors:
+		- '#Call to an undefined method PHPUnit_Framework_MockObject_MockObject::[a-zA-Z0-9_]+\(\)#'
diff --git a/ruleset.xml b/ruleset.xml
@@ -0,0 +1,17 @@
+<?xml version="1.0"?>
+<ruleset name="PHPStan Nette class reflection extension">
+	<rule ref="vendor/consistence/coding-standard/Consistence/ruleset.xml"/>
+	<rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/ruleset.xml">
+		<exclude name="SlevomatCodingStandard.Files.TypeNameMatchesFileName"/>
+		<exclude name="SlevomatCodingStandard.Namespaces.FullyQualifiedClassNameAfterKeyword"/>
+		<exclude name="SlevomatCodingStandard.Namespaces.UseOnlyWhitelistedNamespaces"/>
+		<exclude name="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly"/>
+	</rule>
+	<rule ref="SlevomatCodingStandard.Typehints.TypeHintDeclaration">
+		<properties>
+			<property name="usefulAnnotations" type="array" value="
+				@dataProvider
+			"/>
+		</properties>
+	</rule>
+</ruleset>
diff --git a/src/Reflection/Nette/HtmlClassReflectionExtension.php b/src/Reflection/Nette/HtmlClassReflectionExtension.php
@@ -1,4 +1,4 @@
-<?php declare(strict_types=1);
+<?php declare(strict_types = 1);
 
 namespace PHPStan\Reflection\Nette;
 
@@ -32,5 +32,4 @@ public function getProperty(ClassReflection $classReflection, string $propertyNa
 		return new HtmlPropertyReflection($classReflection);
 	}
 
-
 }
diff --git a/src/Reflection/Nette/HtmlMethodReflection.php b/src/Reflection/Nette/HtmlMethodReflection.php
@@ -1,4 +1,4 @@
-<?php declare(strict_types=1);
+<?php declare(strict_types = 1);
 
 namespace PHPStan\Reflection\Nette;
 
@@ -13,7 +13,7 @@ class HtmlMethodReflection implements MethodReflection
 
 	/** @var string */
 	private $name;
-	
+
 	/** @var \PHPStan\Reflection\ClassReflection */
 	private $declaringClass;
 
diff --git a/src/Reflection/Nette/HtmlPropertyReflection.php b/src/Reflection/Nette/HtmlPropertyReflection.php
@@ -1,4 +1,4 @@
-<?php declare(strict_types=1);
+<?php declare(strict_types = 1);
 
 namespace PHPStan\Reflection\Nette;
 
diff --git a/src/Reflection/Nette/NetteObjectClassReflectionExtension.php b/src/Reflection/Nette/NetteObjectClassReflectionExtension.php
@@ -1,4 +1,4 @@
-<?php declare(strict_types=1);
+<?php declare(strict_types = 1);
 
 namespace PHPStan\Reflection\Nette;
 
@@ -82,4 +82,5 @@ private function getTraitNames(\ReflectionClass $class): array
 
 		return $traitNames;
 	}
+
 }
diff --git a/src/Reflection/Nette/NetteObjectEventListenerMethodReflection.php b/src/Reflection/Nette/NetteObjectEventListenerMethodReflection.php
@@ -1,4 +1,4 @@
-<?php declare(strict_types=1);
+<?php declare(strict_types = 1);
 
 namespace PHPStan\Reflection\Nette;
 
diff --git a/src/Reflection/Nette/NetteObjectPropertyReflection.php b/src/Reflection/Nette/NetteObjectPropertyReflection.php
@@ -1,4 +1,4 @@
-<?php declare(strict_types=1);
+<?php declare(strict_types = 1);
 
 namespace PHPStan\Reflection\Nette;
 
diff --git a/src/Reflection/Nette/SmartObjectPropertiesClassReflectionExtension.php b/src/Reflection/Nette/SmartObjectPropertiesClassReflectionExtension.php
@@ -1,4 +1,4 @@
-<?php declare(strict_types=1);
+<?php declare(strict_types = 1);
 
 namespace PHPStan\Reflection\Nette;
 
diff --git a/tests/Reflection/Nette/HtmlClassReflectionExtensionTest.php b/tests/Reflection/Nette/HtmlClassReflectionExtensionTest.php
@@ -0,0 +1,102 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Reflection\Nette;
+
+use PHPStan\Reflection\ClassReflection;
+use PHPStan\Type\MixedType;
+use PHPStan\Type\ObjectType;
+
+class HtmlClassReflectionExtensionTest extends \PHPUnit_Framework_TestCase
+{
+
+	/** @var \PHPStan\Reflection\Nette\HtmlClassReflectionExtension */
+	private $extension;
+
+	protected function setUp()
+	{
+		$this->extension = new HtmlClassReflectionExtension();
+	}
+
+	public function dataHasMethod(): array
+	{
+		return [
+			[
+				\Nette\Utils\Html::class,
+				true,
+			],
+			[
+				\stdClass::class,
+				false,
+			],
+		];
+	}
+
+	/**
+	 * @dataProvider dataHasMethod
+	 * @param string $className
+	 * @param bool $result
+	 */
+	public function testHasMethod(string $className, bool $result)
+	{
+		$classReflection = $this->createMock(ClassReflection::class);
+		$classReflection->method('getName')->will($this->returnValue($className));
+		$this->assertSame($result, $this->extension->hasMethod($classReflection, 'href'));
+	}
+
+	public function testGetMethod()
+	{
+		$classReflection = $this->createMock(ClassReflection::class);
+		$classReflection->method('getName')->will($this->returnValue(\Nette\Utils\Html::class));
+		$methodReflection = $this->extension->getMethod($classReflection, 'href');
+		$this->assertSame('href', $methodReflection->getName());
+		$this->assertSame($classReflection, $methodReflection->getDeclaringClass());
+		$this->assertFalse($methodReflection->isStatic());
+		$this->assertEmpty($methodReflection->getParameters());
+		$this->assertTrue($methodReflection->isVariadic());
+		$this->assertFalse($methodReflection->isPrivate());
+		$this->assertTrue($methodReflection->isPublic());
+		$this->assertInstanceOf(ObjectType::class, $methodReflection->getReturnType());
+		$this->assertSame(\Nette\Utils\Html::class, $methodReflection->getReturnType()->getClass());
+		$this->assertFalse($methodReflection->getReturnType()->isNullable());
+	}
+
+	public function dataHasProperty(): array
+	{
+		return [
+			[
+				\Nette\Utils\Html::class,
+				true,
+			],
+			[
+				\stdClass::class,
+				false,
+			],
+		];
+	}
+
+	/**
+	 * @dataProvider dataHasProperty
+	 * @param string $className
+	 * @param bool $result
+	 */
+	public function testHasProperty(string $className, bool $result)
+	{
+		$classReflection = $this->createMock(ClassReflection::class);
+		$classReflection->method('getName')->will($this->returnValue($className));
+		$this->assertSame($result, $this->extension->hasProperty($classReflection, 'href'));
+	}
+
+	public function testGetProperty()
+	{
+		$classReflection = $this->createMock(ClassReflection::class);
+		$classReflection->method('getName')->will($this->returnValue(\Nette\Utils\Html::class));
+		$propertyReflection = $this->extension->getProperty($classReflection, 'href');
+		$this->assertSame($classReflection, $propertyReflection->getDeclaringClass());
+		$this->assertFalse($propertyReflection->isStatic());
+		$this->assertFalse($propertyReflection->isPrivate());
+		$this->assertTrue($propertyReflection->isPublic());
+		$this->assertInstanceOf(MixedType::class, $propertyReflection->getType());
+		$this->assertTrue($propertyReflection->getType()->isNullable());
+	}
+
+}
diff --git a/tests/bootstrap.php b/tests/bootstrap.php
@@ -0,0 +1,3 @@
+<?php declare(strict_types = 1);
+
+require_once __DIR__ . '/../vendor/autoload.php';
diff --git a/tests/phpunit.xml b/tests/phpunit.xml
@@ -0,0 +1,26 @@
+<phpunit
+		bootstrap="bootstrap.php"
+		colors="true"
+		backupGlobals="false"
+		backupStaticAttributes="false"
+		beStrictAboutChangesToGlobalState="true"
+		beStrictAboutOutputDuringTests="true"
+		beStrictAboutTestsThatDoNotTestAnything="true"
+		beStrictAboutTodoAnnotatedTests="true"
+		failOnRisky="true"
+		failOnWarning="true"
+>
+	<filter>
+		<whitelist>
+			<directory suffix=".php">../src</directory>
+		</whitelist>
+	</filter>
+	<logging>
+		<log
+				type="coverage-text"
+				target="php://stdout"
+				showUncoveredFiles="true"
+				showOnlySummary="true"
+		/>
+	</logging>
+</phpunit>

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+parameters:`
	`2`	`+ ignoreErrors:`
	`3`	`+ - '#Call to an undefined method PHPUnit_Framework_MockObject_MockObject::[a-zA-Z0-9_]+\(\)#'`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<?php declare(strict_types=1);`
	`1`	`+<?php declare(strict_types = 1);`
`2`	`2`
`3`	`3`	`namespace PHPStan\Reflection\Nette;`
`4`	`4`
`@@ -32,5 +32,4 @@ public function getProperty(ClassReflection $classReflection, string $propertyNa`
`32`	`32`	`return new HtmlPropertyReflection($classReflection);`
`33`	`33`	`}`
`34`	`34`
`35`		`-`
`36`	`35`	`}`