Update DataProviderReturnTypeIgnoreExtension.php

staabm · staabm · commit 8b8376765250 · 2025-10-27T09:49:58.000+01:00
diff --git a/src/Type/PHPUnit/DataProviderReturnTypeIgnoreExtension.php b/src/Type/PHPUnit/DataProviderReturnTypeIgnoreExtension.php
@@ -27,20 +27,20 @@ public function __construct(
 
 	public function shouldIgnore(Error $error, Node $node, Scope $scope): bool
 	{
-		if (!$scope->isInClass()) {
+		if ($error->getIdentifier() !== 'missingType.iterableValue') {
 			return false;
 		}
 
-		if ($error->getIdentifier() !== 'missingType.iterableValue') {
+		if (!$scope->isInClass()) {
 			return false;
 		}
+		$classReflection = $scope->getClassReflection();
 
 		$methodReflection = $scope->getFunction();
 		if ($methodReflection === null) {
 			return false;
 		}
 
-		$classReflection = $scope->getClassReflection();
 		$testMethods = $this->testMethodsHelper->getTestMethods($classReflection, $scope);
 		foreach ($testMethods as $testMethod) {
 			foreach ($this->dataProviderHelper->getDataProviderMethods($scope, $testMethod, $classReflection) as [, $providerMethodName]) {

Original file line number	Diff line number	Diff line change
`@@ -27,20 +27,20 @@ public function __construct(`
`27`	`27`
`28`	`28`	`public function shouldIgnore(Error $error, Node $node, Scope $scope): bool`
`29`	`29`	`{`
`30`		`- if (!$scope->isInClass()) {`
	`30`	`+ if ($error->getIdentifier() !== 'missingType.iterableValue') {`
`31`	`31`	`return false;`
`32`	`32`	`}`
`33`	`33`
`34`		`- if ($error->getIdentifier() !== 'missingType.iterableValue') {`
	`34`	`+ if (!$scope->isInClass()) {`
`35`	`35`	`return false;`
`36`	`36`	`}`
	`37`	`+ $classReflection = $scope->getClassReflection();`
`37`	`38`
`38`	`39`	`$methodReflection = $scope->getFunction();`
`39`	`40`	`if ($methodReflection === null) {`
`40`	`41`	`return false;`
`41`	`42`	`}`
`42`	`43`
`43`		`- $classReflection = $scope->getClassReflection();`
`44`	`44`	`$testMethods = $this->testMethodsHelper->getTestMethods($classReflection, $scope);`
`45`	`45`	`foreach ($testMethods as $testMethod) {`
`46`	`46`	`foreach ($this->dataProviderHelper->getDataProviderMethods($scope, $testMethod, $classReflection) as [, $providerMethodName]) {`