Simplify code thanks to BetterReflection update

Author: ondrejmirtes

src/Reflection/Php/PhpPropertyReflection.php

@@ -234,14 +234,7 @@ public function isAbstract(): TrinaryLogic
 
 	public function isFinal(): TrinaryLogic
 	{
-		if ($this->reflection->isFinal()) {
-			return TrinaryLogic::createYes();
-		}
-		if ($this->reflection->isPrivate()) {
-			return TrinaryLogic::createNo();
-		}
-
-		return TrinaryLogic::createFromBoolean($this->isPrivateSet());
+		return TrinaryLogic::createFromBoolean($this->reflection->isFinal());
 	}
 
 	public function isVirtual(): TrinaryLogic
@@ -277,32 +270,12 @@ public function getHook(string $hookType): ExtendedMethodReflection
 
 	public function isProtectedSet(): bool
 	{
-		if ($this->reflection->isProtectedSet()) {
-			return true;
-		}
-
-		if ($this->isReadOnly()) {
-			return !$this->isPrivate() && !$this->reflection->isPrivateSet();
-		}
-
-		return false;
+		return $this->reflection->isProtectedSet();
 	}
 
 	public function isPrivateSet(): bool
 	{
-		if ($this->reflection->isPrivateSet()) {
-			return true;
-		}
-
-		if ($this->reflection->isProtectedSet()) {
-			return false;
-		}
-
-		if ($this->isReadOnly()) {
-			return $this->isPrivate();
-		}
-
-		return false;
+		return $this->reflection->isPrivateSet();
 	}
 
 }

tests/PHPStan/Rules/Properties/AccessPropertiesInAssignRuleTest.php

@@ -150,11 +150,11 @@ public function testAsymmetricVisibility(): void
 				70,
 			],
 			[
-				'Assign to protected(set) property WriteAsymmetricVisibility\ReadonlyProps::$b.',
+				'Access to protected property WriteAsymmetricVisibility\ReadonlyProps::$b.',
 				71,
 			],
 			[
-				'Assign to private(set) property WriteAsymmetricVisibility\ReadonlyProps::$c.',
+				'Access to private property WriteAsymmetricVisibility\ReadonlyProps::$c.',
 				72,
 			],
 			[

tests/PHPStan/Rules/Properties/PropertyAssignRefRuleTest.php

@@ -26,7 +26,7 @@ public function testRule(): void
 
 		$this->analyse([__DIR__ . '/data/property-assign-ref.php'], [
 			[
-				'Property PropertyAssignRef\Foo::$foo with private(set) visibility is assigned by reference.',
+				'Property PropertyAssignRef\Foo::$foo with private visibility is assigned by reference.',
 				25,
 			],
 			[