faster

Author: staabm

src/Rules/Arrays/DuplicateKeysInLiteralArraysRule.php

@@ -52,6 +52,7 @@ public function processNode(Node $node, Scope $scope): array
 		 */
 		$autoGeneratedIndex = null;
 		$seenKeys = [];
+		$seenUnions = [];
 		foreach ($node->getItemNodes() as $itemNode) {
 			$item = $itemNode->getArrayItem();
 			if ($item === null) {
@@ -88,29 +89,42 @@ public function processNode(Node $node, Scope $scope): array
 			}
 
 			$duplicate = false;
-			$newValuesType = $keyType;
+			$newValuesType = $keyValues;
 			foreach ($seenKeys as $seenKey) {
-				if ($seenKey instanceof UnionType) {
-					continue;
+				$offset = array_search($seenKey, $newValuesType, true);
+				if ($offset !== false) {
+					unset($newValuesType[$offset]);
 				}
-				$newValuesType = TypeCombinator::remove($newValuesType, $seenKey);
 
 				if (
-					$newValuesType instanceof NeverType
-					|| $newValuesType->isSuperTypeOf($seenKey)->yes()
+					$newValuesType === []
 				) {
 					$duplicate = true;
 					break;
 				}
 			}
 
-			if (!$newValuesType instanceof NeverType) {
-				if (!$newValuesType instanceof UnionType) {
-					foreach ($seenKeys as $k => $seenKey) {
-						$seenKeys[$k] = TypeCombinator::remove($seenKey, $newValuesType);
+			if (
+				$newValuesType !== []
+			) {
+				if (count($newValuesType) === 1) {
+					$newValue = $newValuesType[array_key_first($newValuesType)];
+					foreach ($seenUnions as $k => $seenKey) {
+						$offset = array_search($newValue, $seenKey, true);
+						if ($offset !== false) {
+							unset($seenUnions[$k][$offset]);
+
+							if (count($seenUnions[$k]) === 1) {
+								$ukey = array_key_first($seenUnions[$k]);
+								$seenKeys[] = $seenUnions[$k][$ukey];
+								unset($seenUnions[$k]);
+							}
+						}
 					}
+					$seenKeys[] = $newValue;
+				} else {
+					$seenUnions[] = $newValuesType;
 				}
-				$seenKeys[] = $newValuesType;
 			}
 
 			foreach ($keyValues as $value) {