Avoid crashing on enum without value

Author: VincentLanglet

src/Reflection/ClassReflection.php

@@ -3,6 +3,7 @@
 namespace PHPStan\Reflection;
 
 use Attribute;
+use LogicException;
 use PhpParser\Node\Arg;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Identifier;
@@ -945,7 +946,11 @@ public function getEnumCases(): array
 		foreach ($this->reflection->getCases() as $case) {
 			$valueType = null;
 			if ($case instanceof ReflectionEnumBackedCase) {
-				$valueType = $this->initializerExprTypeResolver->getType($case->getValueExpression(), $initializerExprContext);
+				try {
+					$valueType = $this->initializerExprTypeResolver->getType($case->getValueExpression(), $initializerExprContext);
+				} catch (LogicException) {
+					// Enum case does not have a value
+				}
 			}
 			$caseName = $case->getName();
 			$attributes = $this->attributeReflectionFactory->fromNativeReflection($case->getAttributes(), InitializerExprContext::fromClass($this->getName(), $this->getFileName()));
@@ -972,7 +977,11 @@ public function getEnumCase(string $name): EnumCaseReflection
 		$case = $this->reflection->getCase($name);
 		$valueType = null;
 		if ($case instanceof ReflectionEnumBackedCase) {
-			$valueType = $this->initializerExprTypeResolver->getType($case->getValueExpression(), InitializerExprContext::fromClassReflection($this));
+			try {
+				$valueType = $this->initializerExprTypeResolver->getType($case->getValueExpression(), InitializerExprContext::fromClassReflection($this));
+			} catch (LogicException) {
+				// Enum case does not have a value
+			}
 		}
 
 		$attributes = $this->attributeReflectionFactory->fromNativeReflection($case->getAttributes(), InitializerExprContext::fromClass($this->getName(), $this->getFileName()));

tests/PHPStan/Analyser/AnalyserIntegrationTest.php

@@ -1163,6 +1163,15 @@ public function testBug8537(): void
 		$this->assertNoErrors($errors);
 	}
 
+	#[RequiresPhp('>= 8.0')]
+	public function testBug7927(): void
+	{
+		$errors = $this->runAnalyse(__DIR__ . '/data/bug-7927.php');
+		$this->assertCount(2, $errors);
+		$this->assertSame('Enum case Bug7927\Test::One does not have a value but the enum is backed with the "int" type.', $errors[0]->getMessage());
+		$this->assertSame('Enum case Bug7927\Test::Two does not have a value but the enum is backed with the "int" type.', $errors[1]->getMessage());
+	}
+
 	public function testBug8146(): void
 	{
 		$errors = $this->runAnalyse(__DIR__ . '/data/bug-8146b.php');

tests/PHPStan/Analyser/data/bug-7927.php

@@ -0,0 +1,26 @@
+<?php declare(strict_types = 1);
+
+namespace Bug7927;
+
+enum Test : int
+{
+	case One;
+	case Two;
+}
+
+$v = Test::One;
+
+function doIt(Test $v) : string
+{
+	switch($v)
+	{
+		case Test::One:
+			return "One";
+		case Test::Two:
+			return "Two";
+		default:
+			throw new \ErrorException("Unknown '{$v->name}'.");
+	}
+}
+
+echo doIt($v);