s/s/, ->yes

DanielEScherzer · DanielEScherzer · commit 091db2f1cb54 · 2025-09-15T14:03:29.000-07:00
diff --git a/src/Rules/FunctionDefinitionCheck.php b/src/Rules/FunctionDefinitionCheck.php
@@ -204,7 +204,7 @@ public function checkAnonymousFunction(
 			return $errors;
 		}
 		if ($returnTypeNode instanceof FullyQualified && $returnTypeNode->name === 'void') {
-			foreach ($attribGroupss as $attribGroup) {
+			foreach ($attribGroups as $attribGroup) {
 				foreach ($attribGroup->attrs as $attrib) {
 					if (strtolower($attrib->name) === 'nodiscard') {
 						$errors[] = RuleErrorBuilder::message($noDiscardVoidReturnMessage)
@@ -495,7 +495,7 @@ private function checkParametersAcceptor(
 					->build();
 			}
 		}
-		if ($parametersAcceptor->hasNoDiscardAttribute()) {
+		if ($parametersAcceptor->hasNoDiscardAttribute()->yes()) {
 			$returnType = $functionNode->getReturnType();
 			if ($returnType instanceof FullyQualified
 				&& $returnType->name === 'void'

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ public function checkAnonymousFunction(`
`204`	`204`	`return $errors;`
`205`	`205`	`}`
`206`	`206`	`if ($returnTypeNode instanceof FullyQualified && $returnTypeNode->name === 'void') {`
`207`		`- foreach ($attribGroupss as $attribGroup) {`
	`207`	`+ foreach ($attribGroups as $attribGroup) {`
`208`	`208`	`foreach ($attribGroup->attrs as $attrib) {`
`209`	`209`	`if (strtolower($attrib->name) === 'nodiscard') {`
`210`	`210`	`$errors[] = RuleErrorBuilder::message($noDiscardVoidReturnMessage)`
`@@ -495,7 +495,7 @@ private function checkParametersAcceptor(`
`495`	`495`	`->build();`
`496`	`496`	`}`
`497`	`497`	`}`
`498`		`- if ($parametersAcceptor->hasNoDiscardAttribute()) {`
	`498`	`+ if ($parametersAcceptor->hasNoDiscardAttribute()->yes()) {`
`499`	`499`	`$returnType = $functionNode->getReturnType();`
`500`	`500`	`if ($returnType instanceof FullyQualified`
`501`	`501`	`&& $returnType->name === 'void'`