Array without 0 in key type is not a list

Author: VincentLanglet

src/Type/ArrayType.php

@@ -290,6 +290,10 @@ public function isList(): TrinaryLogic
 			return TrinaryLogic::createNo();
 		}
 
+		if ($this->getKeyType()->isSuperTypeOf(new ConstantIntegerType(0))->no()) {
+			return TrinaryLogic::createNo();
+		}
+
 		return TrinaryLogic::createMaybe();
 	}
 

tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php

@@ -3262,6 +3262,22 @@ public function testBug9009(): void
 		$this->analyse([__DIR__ . '/data/bug-9009.php'], []);
 	}
 
+	public function testBug9487(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkNullables = false;
+		$this->checkUnionTypes = false;
+		$this->checkExplicitMixed = false;
+
+		$this->analyse([__DIR__ . '/data/bug-9487.php'], [
+			[
+				'Parameter #1 $x of method Bug9487\HelloWorld::sayHello() expects list<string>, array<int<1, max>, string> given.',
+				15,
+				'array<int<1, max>, string> is not a list.',
+			],
+		]);
+	}
+
 	public function testBuSplObjectStorageRemove(): void
 	{
 		$this->checkThisOnly = false;

tests/PHPStan/Rules/Methods/data/bug-9487.php

@@ -0,0 +1,17 @@
+<?php declare(strict_types = 1);
+
+namespace Bug9487;
+
+class HelloWorld
+{
+	/** @param list<string> $x */
+	public function sayHello($x): void
+	{
+	}
+
+	/** @param array<positive-int, string> $x */
+	public function invoke($x): void
+	{
+		$this->sayHello($x);
+	}
+}