Readonly property can override get-only property declared in interface

Author: ondrejmirtes

src/Rules/Properties/OverridingPropertyRule.php

@@ -74,13 +74,18 @@ public function processNode(Node $node, Scope $scope): array
 				))->identifier('property.readWrite')->nonIgnorable()->build();
 			}
 		} elseif ($node->isReadOnly()) {
-			$errors[] = RuleErrorBuilder::message(sprintf(
-				'Readonly property %s::$%s overrides readwrite property %s::$%s.',
-				$classReflection->getDisplayName(),
-				$node->getName(),
-				$prototype->getDeclaringClass()->getDisplayName(),
-				$node->getName(),
-			))->identifier('property.readOnly')->nonIgnorable()->build();
+			if (
+				!$this->phpVersion->supportsPropertyHooks()
+				|| $prototype->isWritable()
+			) {
+				$errors[] = RuleErrorBuilder::message(sprintf(
+					'Readonly property %s::$%s overrides readwrite property %s::$%s.',
+					$classReflection->getDisplayName(),
+					$node->getName(),
+					$prototype->getDeclaringClass()->getDisplayName(),
+					$node->getName(),
+				))->identifier('property.readOnly')->nonIgnorable()->build();
+			}
 		}
 
 		if ($prototype->isPublic()) {

tests/PHPStan/Rules/Properties/OverridingPropertyRuleTest.php

@@ -253,4 +253,14 @@ public function testBug12466(): void
 		]);
 	}
 
+	public function testBug12586(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4.');
+		}
+
+		$this->reportMaybes = true;
+		$this->analyse([__DIR__ . '/data/bug-12586.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/bug-12586.php

@@ -0,0 +1,21 @@
+<?php // lint >= 8.4
+
+declare(strict_types=1);
+
+namespace Bug12586;
+
+interface Foo
+{
+	public string $bar {
+		get;
+	}
+}
+
+readonly class FooImpl implements Foo
+{
+	public function __construct(
+		public string $bar,
+	)
+	{
+	}
+}