ObjectType: fix isEnum

Author: janedbal

src/Type/ObjectType.php

@@ -4,6 +4,7 @@
 
 use ArrayAccess;
 use ArrayObject;
+use BackedEnum;
 use Closure;
 use Countable;
 use Iterator;
@@ -44,7 +45,10 @@
 use PHPStan\Type\Traits\NonGeneralizableTypeTrait;
 use PHPStan\Type\Traits\NonGenericTypeTrait;
 use PHPStan\Type\Traits\UndecidedComparisonTypeTrait;
+use Stringable;
+use Throwable;
 use Traversable;
+use UnitEnum;
 use function array_key_exists;
 use function array_map;
 use function array_values;
@@ -730,7 +734,23 @@ public function isEnum(): TrinaryLogic
 			return TrinaryLogic::createMaybe();
 		}
 
-		return TrinaryLogic::createFromBoolean($classReflection->isEnum());
+		if (
+			$classReflection->isEnum()
+			|| $classReflection->is(UnitEnum::class)
+			|| $classReflection->is(BackedEnum::class)
+		) {
+			return TrinaryLogic::createYes();
+		}
+
+		if (
+			$classReflection->isInterface()
+			&& !$classReflection->is(Stringable::class) // enums cannot have __toString
+			&& !$classReflection->is(Throwable::class) // enums cannot extend Exception/Error
+		) {
+			return TrinaryLogic::createMaybe();
+		}
+
+		return TrinaryLogic::createNo();
 	}
 
 	public function canAccessProperties(): TrinaryLogic

tests/PHPStan/Type/ObjectTypeTest.php

@@ -70,6 +70,35 @@ public function testIsIterable(ObjectType $type, TrinaryLogic $expectedResult):
 		);
 	}
 
+	/**
+	 * @return array<array{0: ObjectType, 1: TrinaryLogic}>
+	 */
+	public function dataIsEnum(): array
+	{
+		return [
+			[new ObjectType('UnitEnum'), TrinaryLogic::createYes()],
+			[new ObjectType('BackedEnum'), TrinaryLogic::createYes()],
+			[new ObjectType('Unknown'), TrinaryLogic::createMaybe()],
+			[new ObjectType('Countable'), TrinaryLogic::createMaybe()],
+			[new ObjectType('Stringable'), TrinaryLogic::createNo()],
+			[new ObjectType('Throwable'), TrinaryLogic::createNo()],
+			[new ObjectType('DateTime'), TrinaryLogic::createNo()],
+		];
+	}
+
+	/**
+	 * @dataProvider dataIsEnum
+	 */
+	public function testIsEnum(ObjectType $type, TrinaryLogic $expectedResult): void
+	{
+		$actualResult = $type->isEnum();
+		$this->assertSame(
+			$expectedResult->describe(),
+			$actualResult->describe(),
+			sprintf('%s -> isEnum()', $type->describe(VerbosityLevel::precise())),
+		);
+	}
+
 	public function dataIsCallable(): array
 	{
 		return [