Support integer ranges in sprintf() constant result inference

Author: staabm

src/Type/IntegerRangeType.php

@@ -616,6 +616,9 @@ public function exponentiate(Type $exponent): Type
 		return parent::exponentiate($exponent);
 	}
 
+	/**
+	 * @return list<ConstantIntegerType>
+	 */
 	public function getFiniteTypes(): array
 	{
 		if ($this->min === null || $this->max === null) {

src/Type/Php/SprintfFunctionDynamicReturnTypeExtension.php

@@ -11,6 +11,7 @@
 use PHPStan\Type\Accessory\AccessoryNonFalsyStringType;
 use PHPStan\Type\Accessory\AccessoryNumericStringType;
 use PHPStan\Type\DynamicFunctionReturnTypeExtension;
+use PHPStan\Type\IntegerRangeType;
 use PHPStan\Type\IntersectionType;
 use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
@@ -88,11 +89,20 @@ public function getTypeFromFunctionCall(
 		$combinationsCount = 1;
 		foreach ($args as $arg) {
 			$argType = $scope->getType($arg->value);
-			if (count($argType->getConstantScalarValues()) === 0) {
+			$constantScalarValues = $argType->getConstantScalarValues();
+
+			if (count($constantScalarValues) === 0) {
+				if ($argType instanceof IntegerRangeType) {
+					foreach ($argType->getFiniteTypes() as $finiteType) {
+						$constantScalarValues[] = $finiteType->getValue();
+					}
+				}
+			}
+
+			if (count($constantScalarValues) === 0) {
 				return $returnType;
 			}
 
-			$constantScalarValues = $argType->getConstantScalarValues();
 			$values[] = $constantScalarValues;
 			$combinationsCount *= count($constantScalarValues);
 		}

tests/PHPStan/Analyser/data/dynamic-sprintf.php

@@ -18,4 +18,22 @@ public function doFoo(string $a, string $b, string $c): void
 		assertType("'a b c'|'a b cc'|'a bb c'|'a bb cc'|'aa b c'|'aa b cc'|'aa bb c'|'aa bb cc'", sprintf('%s %s %s', $a, $b, $c));
 	}
 
+	/**
+	 * @param int<0,3> $a
+	 * @param 'b'|'bb' $b
+	 */
+	public function integerRange(int $a, string $b): void
+	{
+		assertType("'0 b'|'0 bb'|'1 b'|'1 bb'|'2 b'|'2 bb'|'3 b'|'3 bb'", sprintf('%d %s', $a, $b));
+	}
+
+	/**
+	 * @param int<0,64> $a
+	 * @param 'b'|'bb' $b
+	 */
+	public function tooBigRange(int $a, string $b): void
+	{
+		assertType("non-falsy-string", sprintf('%d %s', $a, $b));
+	}
+
 }