Respect phpstan level in InvalidKeyInArrayDimFetchRule

Author: VincentLanglet

src/Rules/Arrays/InvalidKeyInArrayDimFetchRule.php

@@ -41,22 +41,27 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		$dimensionType = $scope->getType($node->dim);
-		if ($dimensionType instanceof MixedType) {
-			return [];
-		}
-
 		$varType = $this->ruleLevelHelper->findTypeToCheck(
 			$scope,
 			$node->var,
 			'',
-			static fn (Type $varType): bool => $varType->isArray()->no() || AllowedArrayKeysTypes::getType()->isSuperTypeOf($dimensionType)->yes(),
+			static fn (Type $varType): bool => $varType->isArray()->no(),
 		)->getType();
 
 		if ($varType instanceof ErrorType || $varType->isArray()->no()) {
 			return [];
 		}
 
+		$dimensionType = $this->ruleLevelHelper->findTypeToCheck(
+			$scope,
+			$node->dim,
+			'',
+			static fn (Type $dimType): bool => AllowedArrayKeysTypes::getType()->isSuperTypeOf($dimType)->yes(),
+		)->getType();
+		if ($dimensionType instanceof ErrorType) {
+			return [];
+		}
+
 		$isSuperType = AllowedArrayKeysTypes::getType()->isSuperTypeOf($dimensionType);
 		if ($isSuperType->yes() || ($isSuperType->maybe() && !$this->reportMaybes)) {
 			return [];

tests/PHPStan/Rules/Arrays/InvalidKeyInArrayDimFetchRuleTest.php

@@ -12,10 +12,23 @@
  */
 class InvalidKeyInArrayDimFetchRuleTest extends RuleTestCase
 {
+	private bool $checkUnion = true;
+	private bool $checkExplicitMixed = false;
+	private bool $checkImplicitMixed = false;
 
 	protected function getRule(): Rule
 	{
-		$ruleLevelHelper = new RuleLevelHelper(self::createReflectionProvider(), true, false, true, false, false, false, true);
+		$ruleLevelHelper = new RuleLevelHelper(
+			self::createReflectionProvider(),
+			true,
+			false,
+			$this->checkUnion,
+			$this->checkExplicitMixed,
+			$this->checkImplicitMixed,
+			false,
+			true,
+		);
+
 		return new InvalidKeyInArrayDimFetchRule($ruleLevelHelper, true);
 	}
 
@@ -61,6 +74,95 @@ public function testInvalidKey(): void
 		]);
 	}
 
+	public function testInvalidKeyOnLevel6(): void
+	{
+		$this->checkUnion = false;
+
+		$this->analyse([__DIR__ . '/data/invalid-key-array-dim-fetch.php'], [
+			[
+				'Invalid array key type DateTimeImmutable.',
+				7,
+			],
+			[
+				'Invalid array key type array.',
+				8,
+			],
+			[
+				'Invalid array key type DateTimeImmutable.',
+				31,
+			],
+			[
+				'Invalid array key type DateTimeImmutable.',
+				45,
+			],
+			[
+				'Invalid array key type DateTimeImmutable.',
+				46,
+			],
+			[
+				'Invalid array key type DateTimeImmutable.',
+				47,
+			],
+			[
+				'Invalid array key type stdClass.',
+				47,
+			],
+			[
+				'Invalid array key type DateTimeImmutable.',
+				48,
+			],
+		]);
+	}
+
+	public function testInvalidKeyOnLevel10(): void
+	{
+		$this->checkExplicitMixed = true;
+		$this->checkImplicitMixed = true;
+
+		$this->analyse([__DIR__ . '/data/invalid-key-array-dim-fetch.php'], [
+			[
+				'Invalid array key type DateTimeImmutable.',
+				7,
+			],
+			[
+				'Invalid array key type array.',
+				8,
+			],
+			[
+				'Possibly invalid array key type stdClass|string.',
+				24,
+			],
+			[
+				'Invalid array key type DateTimeImmutable.',
+				31,
+			],
+			[
+				'Possibly invalid array key type mixed.',
+				41,
+			],
+			[
+				'Invalid array key type DateTimeImmutable.',
+				45,
+			],
+			[
+				'Invalid array key type DateTimeImmutable.',
+				46,
+			],
+			[
+				'Invalid array key type DateTimeImmutable.',
+				47,
+			],
+			[
+				'Invalid array key type stdClass.',
+				47,
+			],
+			[
+				'Invalid array key type DateTimeImmutable.',
+				48,
+			],
+		]);
+	}
+
 	#[RequiresPhp('>= 8.1')]
 	public function testBug6315(): void
 	{