Simplify ContainerDynamicReturnTypeExtension

staabm · ondrejmirtes · commit 1ef8abb88ee0 · 2026-01-14T06:31:10.000+01:00
diff --git a/build/PHPStan/Build/ContainerDynamicReturnTypeExtension.php b/build/PHPStan/Build/ContainerDynamicReturnTypeExtension.php
@@ -30,22 +30,14 @@ public function isMethodSupported(MethodReflection $methodReflection): bool
 		], true);
 	}
 
-	public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): Type
+	public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): ?Type
 	{
 		if (count($methodCall->getArgs()) === 0) {
-			return ParametersAcceptorSelector::selectFromArgs(
-				$scope,
-				$methodCall->getArgs(),
-				$methodReflection->getVariants(),
-			)->getReturnType();
+			return null;
 		}
 		$argType = $scope->getType($methodCall->getArgs()[0]->value);
 		if (!$argType instanceof ConstantStringType) {
-			return ParametersAcceptorSelector::selectFromArgs(
-				$scope,
-				$methodCall->getArgs(),
-				$methodReflection->getVariants(),
-			)->getReturnType();
+			return null;
 		}
 
 		$type = new ObjectType($argType->getValue());

Original file line number	Diff line number	Diff line change
`@@ -30,22 +30,14 @@ public function isMethodSupported(MethodReflection $methodReflection): bool`
`30`	`30`	`], true);`
`31`	`31`	`}`
`32`	`32`
`33`		`- public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): Type`
	`33`	`+ public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): ?Type`
`34`	`34`	`{`
`35`	`35`	`if (count($methodCall->getArgs()) === 0) {`
`36`		`- return ParametersAcceptorSelector::selectFromArgs(`
`37`		`- $scope,`
`38`		`- $methodCall->getArgs(),`
`39`		`- $methodReflection->getVariants(),`
`40`		`- )->getReturnType();`
	`36`	`+ return null;`
`41`	`37`	`}`
`42`	`38`	`$argType = $scope->getType($methodCall->getArgs()[0]->value);`
`43`	`39`	`if (!$argType instanceof ConstantStringType) {`
`44`		`- return ParametersAcceptorSelector::selectFromArgs(`
`45`		`- $scope,`
`46`		`- $methodCall->getArgs(),`
`47`		`- $methodReflection->getVariants(),`
`48`		`- )->getReturnType();`
	`40`	`+ return null;`
`49`	`41`	`}`
`50`	`42`
`51`	`43`	`$type = new ObjectType($argType->getValue());`