Report bool properties as too wide when only used with true/false

Author: staabm

src/Php/PhpVersions.php

@@ -43,4 +43,9 @@ public function supportsNamedArgumentAfterUnpackedArgument(): TrinaryLogic
 		return IntegerRangeType::fromInterval(80100, null)->isSuperTypeOf($this->phpVersions)->result;
 	}
 
+	public function supportsTrueAndFalseStandaloneType(): TrinaryLogic
+	{
+		return IntegerRangeType::fromInterval(80200, null)->isSuperTypeOf($this->phpVersions)->result;
+	}
+
 }

src/Rules/TooWideTypehints/TooWidePropertyTypeRule.php

@@ -60,8 +60,15 @@ public function processNode(Node $node, Scope $scope): array
 			$propertyReflection = $classReflection->getNativeProperty($propertyName);
 			$propertyType = $propertyReflection->getWritableType();
 			if (!$propertyType instanceof UnionType) {
-				continue;
+				if (
+					!$propertyReflection->getNativeReflection()->hasType() ||
+					!$propertyType->isBoolean()->yes() ||
+					!$scope->getPhpVersion()->supportsTrueAndFalseStandaloneType()->yes()
+				) {
+					continue;
+				}
 			}
+
 			foreach ($this->extensionProvider->getExtensions() as $extension) {
 				if ($extension->isAlwaysRead($propertyReflection, $propertyName)) {
 					continue 2;
@@ -101,7 +108,9 @@ public function processNode(Node $node, Scope $scope): array
 			$assignedType = TypeCombinator::union(...$assignedTypes);
 			$propertyDescription = $this->describePropertyByName($propertyReflection, $propertyName);
 			$verbosityLevel = VerbosityLevel::getRecommendedLevelByType($propertyType, $assignedType);
-			foreach ($propertyType->getTypes() as $type) {
+
+			$propertyTypes = $propertyType instanceof UnionType ? $propertyType->getTypes() : $propertyType->getFiniteTypes();
+			foreach ($propertyTypes as $type) {
 				if (!$type->isSuperTypeOf($assignedType)->no()) {
 					continue;
 				}

tests/PHPStan/Rules/Comparison/IfConstantConditionRuleTest.php

@@ -182,4 +182,15 @@ public function testBug8926(): void
 		$this->analyse([__DIR__ . '/data/bug-8926.php'], []);
 	}
 
+	public function testBug13384b(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/../TooWideTypehints/data/bug-13384b.php'], [
+			[
+				'If condition is always false.',
+				23,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/TooWideTypehints/TooWidePropertyTypeRuleTest.php

@@ -58,4 +58,30 @@ public function testBug11667(): void
 		$this->analyse([__DIR__ . '/data/bug-11667.php'], []);
 	}
 
+	#[RequiresPhp('>= 8.2')]
+	public function testBug13384(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-13384.php'], [
+			[
+				'Static property Bug13384\ShutdownHandlerFalseDefault::$registered (bool) is never assigned true so it can be removed from the property type.',
+				9,
+			],
+			[
+				'Static property Bug13384\ShutdownHandlerTrueDefault::$registered (bool) is never assigned false so it can be removed from the property type.',
+				34,
+			],
+		]);
+	}
+
+	#[RequiresPhp('< 8.2')]
+	public function testBug13384NoStandaloneTrueFalse(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-13384.php'], []);
+	}
+
+	public function testBug13384b(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-13384b.php'], []);
+	}
+
 }

tests/PHPStan/Rules/TooWideTypehints/data/bug-13384.php

@@ -0,0 +1,55 @@
+<?php declare(strict_types=1);
+
+namespace Bug13384;
+
+use function register_shutdown_function;
+
+final class ShutdownHandlerFalseDefault
+{
+	private static bool $registered = false;
+	private static string $message  = '';
+
+	public static function setMessage(string $message): void
+	{
+		self::register();
+
+		self::$message = $message;
+	}
+
+	private static function register(): void
+	{
+		if (self::$registered) {
+			return;
+		}
+
+		register_shutdown_function(static function (): void
+		{
+			print self::$message;
+		});
+	}
+}
+
+final class ShutdownHandlerTrueDefault
+{
+	private static bool $registered = true;
+	private static string $message  = '';
+
+	public static function setMessage(string $message): void
+	{
+		self::register();
+
+		self::$message = $message;
+	}
+
+	private static function register(): void
+	{
+		if (self::$registered) {
+			return;
+		}
+
+		register_shutdown_function(static function (): void
+		{
+			print self::$message;
+		});
+	}
+}

tests/PHPStan/Rules/TooWideTypehints/data/bug-13384b.php

@@ -0,0 +1,32 @@
+<?php // lint >= 8.2
+
+declare(strict_types=1);
+
+namespace Bug13384b;
+
+use function register_shutdown_function;
+
+final class ShutdownHandlerFooBar
+{
+	private static false $registered = false;
+	private static string $message  = '';
+
+	public static function setMessage(string $message): void
+	{
+		self::register();
+
+		self::$message = $message;
+	}
+
+	private static function register(): void
+	{
+		if (self::$registered) {
+			return;
+		}
+
+		register_shutdown_function(static function (): void
+		{
+			print self::$message;
+		});
+	}
+}