Missing types should always be reported on level 6, not sooner

Author: ondrejmirtes

conf/config.neon

@@ -917,6 +917,7 @@ services:
 		class: PHPStan\Rules\Generics\GenericAncestorsCheck
 		arguments:
 			skipCheckGenericClasses: %featureToggles.skipCheckGenericClasses%
+			checkMissingTypehints: %checkMissingTypehints%
 
 	-
 		class: PHPStan\Rules\Generics\GenericObjectTypeCheck

src/Rules/Generics/GenericAncestorsCheck.php

@@ -34,6 +34,7 @@ public function __construct(
 		private VarianceCheck $varianceCheck,
 		private UnresolvableTypeHelper $unresolvableTypeHelper,
 		private array $skipCheckGenericClasses,
+		private bool $checkMissingTypehints,
 	)
 	{
 	}
@@ -151,26 +152,28 @@ public function check(
 			}
 		}
 
-		foreach (array_keys($unusedNames) as $unusedName) {
-			if (!$this->reflectionProvider->hasClass($unusedName)) {
-				continue;
-			}
+		if ($this->checkMissingTypehints) {
+			foreach (array_keys($unusedNames) as $unusedName) {
+				if (!$this->reflectionProvider->hasClass($unusedName)) {
+					continue;
+				}
 
-			$unusedNameClassReflection = $this->reflectionProvider->getClass($unusedName);
-			if (in_array($unusedNameClassReflection->getName(), $this->skipCheckGenericClasses, true)) {
-				continue;
-			}
-			if (!$unusedNameClassReflection->isGeneric()) {
-				continue;
-			}
+				$unusedNameClassReflection = $this->reflectionProvider->getClass($unusedName);
+				if (in_array($unusedNameClassReflection->getName(), $this->skipCheckGenericClasses, true)) {
+					continue;
+				}
+				if (!$unusedNameClassReflection->isGeneric()) {
+					continue;
+				}
 
-			$messages[] = RuleErrorBuilder::message(sprintf(
-				$genericClassInNonGenericObjectType,
-				$unusedName,
-				implode(', ', array_keys($unusedNameClassReflection->getTemplateTypeMap()->getTypes())),
-			))
-				->identifier('missingType.generics')
-				->build();
+				$messages[] = RuleErrorBuilder::message(sprintf(
+					$genericClassInNonGenericObjectType,
+					$unusedName,
+					implode(', ', array_keys($unusedNameClassReflection->getTemplateTypeMap()->getTypes())),
+				))
+					->identifier('missingType.generics')
+					->build();
+			}
 		}
 
 		return $messages;

src/Rules/PhpDoc/InvalidPhpDocVarTagTypeRule.php

@@ -97,6 +97,17 @@ public function processNode(Node $node, Scope $scope): array
 						->identifier('missingType.iterableValue')
 						->build();
 				}
+
+				foreach ($this->missingTypehintCheck->getNonGenericObjectTypesWithGenericClass($varTagType) as [$innerName, $genericTypeNames]) {
+					$errors[] = RuleErrorBuilder::message(sprintf(
+						'%s contains generic %s but does not specify its types: %s',
+						$identifier,
+						$innerName,
+						implode(', ', $genericTypeNames),
+					))
+						->identifier('missingType.generics')
+						->build();
+				}
 			}
 
 			$escapedIdentifier = SprintfHelper::escapeFormatString($identifier);
@@ -110,17 +121,6 @@ public function processNode(Node $node, Scope $scope): array
 				sprintf('Call-site variance of %%s in generic type %%s in %s is redundant, template type %%s of %%s %%s has the same variance.', $escapedIdentifier),
 			));
 
-			foreach ($this->missingTypehintCheck->getNonGenericObjectTypesWithGenericClass($varTagType) as [$innerName, $genericTypeNames]) {
-				$errors[] = RuleErrorBuilder::message(sprintf(
-					'%s contains generic %s but does not specify its types: %s',
-					$identifier,
-					$innerName,
-					implode(', ', $genericTypeNames),
-				))
-					->identifier('missingType.generics')
-					->build();
-			}
-
 			$referencedClasses = $varTagType->getReferencedClasses();
 			foreach ($referencedClasses as $referencedClass) {
 				if ($this->reflectionProvider->hasClass($referencedClass)) {

tests/PHPStan/Levels/LevelsIntegrationTest.php

@@ -41,6 +41,7 @@ public function dataTopics(): array
 			['coalesce'],
 			['arrayDestructuring'],
 			['listType'],
+			['missingTypes'],
 		];
 		if (PHP_VERSION_ID >= 80300) {
 			$topics[] = ['constantAccesses83'];

tests/PHPStan/Levels/data/missingTypes-6.json

@@ -0,0 +1,7 @@
+[
+    {
+        "message": "Class MissingTypesLevels\\Foo extends generic class MissingTypesLevels\\Generic but does not specify its types: T",
+        "line": 13,
+        "ignorable": true
+    }
+]

tests/PHPStan/Levels/data/missingTypes.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace MissingTypesLevels;
+
+/**
+ * @template T
+ */
+class Generic
+{
+
+}
+
+class Foo extends Generic
+{
+
+}

tests/PHPStan/Rules/Generics/ClassAncestorsRuleTest.php

@@ -21,6 +21,7 @@ protected function getRule(): Rule
 				new VarianceCheck(),
 				new UnresolvableTypeHelper(),
 				[],
+				true,
 			),
 			new CrossCheckInterfacesHelper(),
 		);

tests/PHPStan/Rules/Generics/EnumAncestorsRuleTest.php

@@ -22,6 +22,7 @@ protected function getRule(): Rule
 				new VarianceCheck(),
 				new UnresolvableTypeHelper(),
 				[],
+				true,
 			),
 			new CrossCheckInterfacesHelper(),
 		);

tests/PHPStan/Rules/Generics/InterfaceAncestorsRuleTest.php

@@ -21,6 +21,7 @@ protected function getRule(): Rule
 				new VarianceCheck(),
 				new UnresolvableTypeHelper(),
 				[],
+				true,
 			),
 			new CrossCheckInterfacesHelper(),
 		);

tests/PHPStan/Rules/Generics/UsedTraitsRuleTest.php

@@ -23,6 +23,7 @@ protected function getRule(): Rule
 				new VarianceCheck(),
 				new UnresolvableTypeHelper(),
 				[],
+				true,
 			),
 		);
 	}