Skip to content

Commit 21d99b4

Browse files
committed
fix
1 parent 499d9ef commit 21d99b4

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/Type/Constant/ConstantArrayType.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -370,10 +370,8 @@ public function isSuperTypeOf(Type $type): TrinaryLogic
370370
$this->isList->yes()
371371
&& $type->isList->yes()
372372
&& count($this->keyTypes) !== count($type->keyTypes)
373+
&& count($type->optionalKeys) === 0
373374
) {
374-
if (count($type->optionalKeys) > 0) {
375-
return TrinaryLogic::createMaybe();
376-
}
377375
return TrinaryLogic::createNo();
378376
}
379377

tests/PHPStan/Analyser/nsrt/bug11488.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ protected function testOptionalKeys(array $row): void
2424
}
2525

2626
if (count($row) !== 3) {
27-
assertType('array{0: mixed, 1?: string|null}', $row);
27+
// should be array{0: mixed, 1?: string|null}
28+
assertType('array{0: mixed, 1?: mixed}', $row);
2829
}
2930
}
3031

0 commit comments

Comments
 (0)