simplify

Author: staabm

tests/PHPStan/Type/UnionTypeTest.php

@@ -8,7 +8,6 @@
 use Iterator;
 use PHPStan\Reflection\Native\NativeParameterReflection;
 use PHPStan\Reflection\PassedByReference;
-use PHPStan\ShouldNotHappenException;
 use PHPStan\Testing\PHPStanTestCase;
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\Accessory\AccessoryLiteralStringType;
@@ -177,26 +176,22 @@ public function testSelfCompare(Type $type): void
 	 */
 	public static function dataIsSuperTypeOf(): Iterator
 	{
+		$int = new IntegerType();
+		$string = new StringType();
 		$unionTypeA = new UnionType([
-			new IntegerType(),
-			new StringType(),
+			$int,
+			$string,
 		]);
-		if (
-			!isset($unionTypeA->getTypes()[0])
-			|| !isset($unionTypeA->getTypes()[1])
-		) {
-			throw new ShouldNotHappenException();
-		}
 
 		yield [
 			$unionTypeA,
-			$unionTypeA->getTypes()[0],
+			$int,
 			TrinaryLogic::createYes(),
 		];
 
 		yield [
 			$unionTypeA,
-			$unionTypeA->getTypes()[1],
+			$string,
 			TrinaryLogic::createYes(),
 		];
 
@@ -266,29 +261,25 @@ public static function dataIsSuperTypeOf(): Iterator
 			TrinaryLogic::createNo(),
 		];
 
+		$intersectionTypeB = new IntersectionType([
+			new ObjectType('ArrayObject'),
+			new IterableType(new MixedType(), new ObjectType('DatePeriod')),
+		]);
+		$arrayTypeB = new ArrayType(new MixedType(), new ObjectType('DatePeriod'));
 		$unionTypeB = new UnionType([
-			new IntersectionType([
-				new ObjectType('ArrayObject'),
-				new IterableType(new MixedType(), new ObjectType('DatePeriod')),
-			]),
-			new ArrayType(new MixedType(), new ObjectType('DatePeriod')),
+			$intersectionTypeB,
+			$arrayTypeB,
 		]);
-		if (
-			!isset($unionTypeB->getTypes()[0])
-			|| !isset($unionTypeB->getTypes()[1])
-		) {
-			throw new ShouldNotHappenException();
-		}
 
 		yield [
 			$unionTypeB,
-			$unionTypeB->getTypes()[0],
+			$intersectionTypeB,
 			TrinaryLogic::createYes(),
 		];
 
 		yield [
 			$unionTypeB,
-			$unionTypeB->getTypes()[1],
+			$arrayTypeB,
 			TrinaryLogic::createYes(),
 		];
 
@@ -486,16 +477,12 @@ public function testIsSuperTypeOf(UnionType $type, Type $otherType, TrinaryLogic
 	 */
 	public static function dataIsSubTypeOf(): Iterator
 	{
+		$int = new IntegerType();
+		$string = new StringType();
 		$unionTypeA = new UnionType([
-			new IntegerType(),
-			new StringType(),
+			$int,
+			$string,
 		]);
-		if (
-			!isset($unionTypeA->getTypes()[0])
-			|| !isset($unionTypeA->getTypes()[1])
-		) {
-			throw new ShouldNotHappenException();
-		}
 
 		yield [
 			$unionTypeA,
@@ -517,13 +504,13 @@ public static function dataIsSubTypeOf(): Iterator
 
 		yield [
 			$unionTypeA,
-			$unionTypeA->getTypes()[0],
+			$int,
 			TrinaryLogic::createMaybe(),
 		];
 
 		yield [
 			$unionTypeA,
-			$unionTypeA->getTypes()[1],
+			$string,
 			TrinaryLogic::createMaybe(),
 		];
 
@@ -581,20 +568,16 @@ public static function dataIsSubTypeOf(): Iterator
 			TrinaryLogic::createNo(),
 		];
 
+		$intersectionTypeB = new IntersectionType([
+			new ObjectType('ArrayObject'),
+			new IterableType(new MixedType(), new ObjectType('Item')),
+			new CallableType(),
+		]);
+		$arrayTypeB = new ArrayType(new MixedType(), new ObjectType('Item'));
 		$unionTypeB = new UnionType([
-			new IntersectionType([
-				new ObjectType('ArrayObject'),
-				new IterableType(new MixedType(), new ObjectType('Item')),
-				new CallableType(),
-			]),
-			new ArrayType(new MixedType(), new ObjectType('Item')),
+			$intersectionTypeB,
+			$arrayTypeB,
 		]);
-		if (
-			!isset($unionTypeB->getTypes()[0])
-			|| !isset($unionTypeB->getTypes()[1])
-		) {
-			throw new ShouldNotHappenException();
-		}
 
 		yield [
 			$unionTypeB,
@@ -616,13 +599,13 @@ public static function dataIsSubTypeOf(): Iterator
 
 		yield [
 			$unionTypeB,
-			$unionTypeB->getTypes()[0],
+			$intersectionTypeB,
 			TrinaryLogic::createMaybe(),
 		];
 
 		yield [
 			$unionTypeB,
-			$unionTypeB->getTypes()[1],
+			$arrayTypeB,
 			TrinaryLogic::createMaybe(),
 		];