refactor

Author: staabm

src/Rules/Classes/ClassAttributesRule.php

@@ -38,22 +38,27 @@ public function processNode(Node $node, Scope $scope): array
 			'class',
 		);
 
-		$classReflection = $scope->getClassReflection();
+		$classReflection = $node->getClassReflection();
 		if (
-			$classReflection !== null
-			&& ($classReflection->isReadOnly() || $classReflection->isEnum() || $classReflection->isInterface())
+			$classReflection->isReadOnly()
+			|| $classReflection->isEnum()
+			|| $classReflection->isInterface()
 		) {
-			$message = 'Attribute class AllowDynamicProperties cannot be used with readonly classes.';
+			$typeName = 'readonly class';
+			$identifier = 'class.allowDynamicPropertiesReadonly';
 			if ($classReflection->isEnum()) {
-				$message = 'Attribute class AllowDynamicProperties cannot be used with enums.';
+				$typeName = 'enum';
+				$identifier = 'class.allowDynamicPropertiesEnum';
 			}
 			if ($classReflection->isInterface()) {
-				$message = 'Attribute class AllowDynamicProperties cannot be used with interface.';
+				$typeName = 'interface';
+				$identifier = 'class.allowDynamicPropertiesInterface';
 			}
 
 			if (count($classReflection->getNativeReflection()->getAttributes('AllowDynamicProperties')) > 0) {
-				$errors[] = RuleErrorBuilder::message($message)
-					->identifier('class.allowDynamicPropertiesReadonly')
+				$errors[] = RuleErrorBuilder::message(sprintf('Attribute class AllowDynamicProperties cannot be used with %s.', $typeName))
+					->identifier($identifier)
+					->nonIgnorable()
 					->build();
 			}
 		}

tests/PHPStan/Rules/Classes/ClassAttributesRuleTest.php

@@ -178,11 +178,11 @@ public function testBug12281(): void
 		$this->checkImplicitMixed = true;
 		$this->analyse([__DIR__ . '/data/bug-12281.php'], [
 			[
-				'Attribute class AllowDynamicProperties cannot be used with readonly classes.',
+				'Attribute class AllowDynamicProperties cannot be used with readonly class.',
 				05,
 			],
 			[
-				'Attribute class AllowDynamicProperties cannot be used with enums.',
+				'Attribute class AllowDynamicProperties cannot be used with enum.',
 				12,
 			],
 			[

tests/PHPStan/Rules/Classes/data/bug-12281.php

@@ -14,6 +14,3 @@ enum BlogDataEnum { /* … */ }
 
 #[\AllowDynamicProperties]
 interface BlogDataInterface { /* … */ }
-
-#[\AllowDynamicProperties]
-trait BlogDataTrait { /* … */ }