Remove incorrect CURLOPT_ACCEPT_ENCODING alias

xPaw · xPaw · commit 3428bff73729 · 2024-12-02T21:57:02.000+02:00
Fixes phpstan/phpstan#12171
diff --git a/src/Reflection/ParametersAcceptorSelector.php b/src/Reflection/ParametersAcceptorSelector.php
@@ -919,7 +919,6 @@ private static function getCurlOptValueType(int $curlOpt): ?Type
 		}
 
 		$nullableStringConstants = [
-			'CURLOPT_ACCEPT_ENCODING',
 			'CURLOPT_CUSTOMREQUEST',
 			'CURLOPT_DNS_INTERFACE',
 			'CURLOPT_DNS_LOCAL_IP4',
@@ -1032,7 +1031,7 @@ private static function getCurlOptValueType(int $curlOpt): ?Type
 
 		$stringConstants = [
 			'CURLOPT_COOKIEFILE',
-			'CURLOPT_ENCODING',
+			'CURLOPT_ENCODING', // Alias: CURLOPT_ACCEPT_ENCODING
 			'CURLOPT_PRE_PROXY',
 			'CURLOPT_PRIVATE',
 			'CURLOPT_PROXY',
diff --git a/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php b/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
@@ -1354,7 +1354,7 @@ public function testCurlSetOpt(): void
 			],
 			[
 				'Parameter #3 $value of function curl_setopt expects array<int, string>, array<string, string> given.',
-				73,
+				75,
 			],
 		]);
 	}
diff --git a/tests/PHPStan/Rules/Functions/data/curl_setopt.php b/tests/PHPStan/Rules/Functions/data/curl_setopt.php
@@ -62,6 +62,8 @@ public function allGood(string $url, array $header) {
 		curl_setopt($curl, CURLOPT_PRE_PROXY, '');
 		curl_setopt($curl, CURLOPT_PROXY, '');
 		curl_setopt($curl, CURLOPT_PRIVATE, '');
+		curl_setopt($curl, CURLOPT_ENCODING, '');
+		curl_setopt($curl, CURLOPT_ACCEPT_ENCODING, '');
 	}
 
 	public function bug9263() {

Original file line number	Diff line number	Diff line change
`@@ -1354,7 +1354,7 @@ public function testCurlSetOpt(): void`
`1354`	`1354`	`],`
`1355`	`1355`	`[`
`1356`	`1356`	`'Parameter #3 $value of function curl_setopt expects array<int, string>, array<string, string> given.',`
`1357`		`- 73,`
	`1357`	`+ 75,`
`1358`	`1358`	`],`
`1359`	`1359`	`]);`
`1360`	`1360`	`}`
Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,8 @@ public function allGood(string $url, array $header) {`
`62`	`62`	`curl_setopt($curl, CURLOPT_PRE_PROXY, '');`
`63`	`63`	`curl_setopt($curl, CURLOPT_PROXY, '');`
`64`	`64`	`curl_setopt($curl, CURLOPT_PRIVATE, '');`
	`65`	`+ curl_setopt($curl, CURLOPT_ENCODING, '');`
	`66`	`+ curl_setopt($curl, CURLOPT_ACCEPT_ENCODING, '');`
`65`	`67`	`}`
`66`	`68`
`67`	`69`	`public function bug9263() {`