identifier

Author: DanielEScherzer

src/Rules/FunctionDefinitionCheck.php

@@ -10,7 +10,6 @@
 use PhpParser\Node\Identifier;
 use PhpParser\Node\IntersectionType;
 use PhpParser\Node\Name;
-use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\NullableType;
 use PhpParser\Node\Param;
 use PhpParser\Node\Stmt\ClassMethod;
@@ -203,7 +202,7 @@ public function checkAnonymousFunction(
 		if ($returnTypeNode === null) {
 			return $errors;
 		}
-		if ($returnTypeNode instanceof FullyQualified && $returnTypeNode->name === 'void') {
+		if ($returnTypeNode instanceof Identifier && $returnTypeNode->name === 'void') {
 			foreach ($attribGroups as $attribGroup) {
 				foreach ($attribGroup->attrs as $attrib) {
 					if (strtolower($attrib->name->name) === 'nodiscard') {
@@ -497,7 +496,7 @@ private function checkParametersAcceptor(
 		}
 		if ($parametersAcceptor->hasNoDiscardAttribute()->yes()) {
 			$returnType = $functionNode->getReturnType();
-			if ($returnType instanceof FullyQualified
+			if ($returnType instanceof Identifier
 				&& $returnType->name === 'void'
 			) {
 				$errors[] = RuleErrorBuilder::message($noDiscardVoidReturnMessage)

tests/PHPStan/Rules/Functions/ExistingClassesInClosureTypehintsRuleTest.php

@@ -358,7 +358,7 @@ public function testNoDiscardVoid(): void
 		$this->analyse([__DIR__ . '/data/closure-typehints-nodiscard.php'], [
 			[
 				'Attribute NoDiscard cannot be used on void anonymous function.',
-				17,
+				5,
 			],
 		]);
 	}