Test WritingToReadOnlyPropertiesRule for hooked properties

Author: ondrejmirtes

src/Reflection/Php/PhpPropertyReflection.php

@@ -179,7 +179,15 @@ public function isReadable(): bool
 
 	public function isWritable(): bool
 	{
-		return true;
+		if ($this->isStatic()) {
+			return true;
+		}
+
+		if (!$this->isVirtual()->yes()) {
+			return true;
+		}
+
+		return $this->hasHook('set');
 	}
 
 	public function getDeprecatedDescription(): ?string

tests/PHPStan/Rules/Properties/WritingToReadOnlyPropertiesRuleTest.php

@@ -5,6 +5,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleLevelHelper;
 use PHPStan\Testing\RuleTestCase;
+use const PHP_VERSION_ID;
 
 /**
  * @extends RuleTestCase<WritingToReadOnlyPropertiesRule>
@@ -87,4 +88,23 @@ public function testConflictingAnnotationProperty(): void
 		]);
 	}
 
+	public function testPropertyHooks(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4.');
+		}
+
+		$this->checkThisOnly = false;
+		$this->analyse([__DIR__ . '/data/writing-to-read-only-hooked-properties.php'], [
+			[
+				'Property WritingToReadOnlyHookedProperties\Foo::$i is not writable.',
+				16,
+			],
+			[
+				'Property WritingToReadOnlyHookedProperties\Bar::$i is not writable.',
+				32,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/writing-to-read-only-hooked-properties.php

@@ -0,0 +1,49 @@
+<?php // lint >= 8.4
+
+namespace WritingToReadOnlyHookedProperties;
+
+interface Foo
+{
+
+	public int $i {
+		// virtual, not writable
+		get;
+	}
+
+}
+
+function (Foo $f): void {
+	$f->i = 1;
+};
+
+class Bar
+{
+
+	public int $i {
+		// virtual, not writable
+		get {
+			return 1;
+		}
+	}
+
+}
+
+function (Bar $b): void {
+	$b->i = 1;
+};
+
+class Baz
+{
+
+	public int $i {
+		// backed, writable
+		get {
+			return $this->i + 1;
+		}
+	}
+
+}
+
+function (Baz $b): void {
+	$b->i = 1;
+};