Do not say that an error is fixable if the old code is same as new code

ondrejmirtes · ondrejmirtes · commit 3b32f1ccd325 · 2025-05-29T10:39:09.000+02:00
diff --git a/src/Analyser/RuleErrorTransformer.php b/src/Analyser/RuleErrorTransformer.php
@@ -133,7 +133,9 @@ public function transform(
 			$printer = new PhpPrinter(['indent' => str_repeat($indentDetector->indentCharacter, $indentDetector->indentSize)]);
 			$newCode = $printer->printFormatPreserving($newStmts, $fileNodes, $oldTokens);
 
-			$fixedErrorDiff = new FixedErrorDiff($hash, $this->differ->diff($oldCode, $newCode));
+			if ($oldCode !== $newCode) {
+				$fixedErrorDiff = new FixedErrorDiff($hash, $this->differ->diff($oldCode, $newCode));
+			}
 		}
 
 		return new Error(

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,9 @@ public function transform(`
`133`	`133`	`$printer = new PhpPrinter(['indent' => str_repeat($indentDetector->indentCharacter, $indentDetector->indentSize)]);`
`134`	`134`	`$newCode = $printer->printFormatPreserving($newStmts, $fileNodes, $oldTokens);`
`135`	`135`
`136`		`- $fixedErrorDiff = new FixedErrorDiff($hash, $this->differ->diff($oldCode, $newCode));`
	`136`	`+ if ($oldCode !== $newCode) {`
	`137`	`+ $fixedErrorDiff = new FixedErrorDiff($hash, $this->differ->diff($oldCode, $newCode));`
	`138`	`+ }`
`137`	`139`	`}`
`138`	`140`
`139`	`141`	`return new Error(`