array_rand() requires a non-empty-array as of php8

Author: staabm

resources/functionMap_php80delta_bleedingEdge.php

@@ -2,7 +2,11 @@
 
 return [
 	'new' => [
+		'array_rand' => ['int|string|array<int,int>|array<int,string>', 'input'=>'non-empty-array', 'num_req'=>'int'],
+		'array_rand\'1' => ['int|string', 'input'=>'non-empty-array'],
 	],
 	'old' => [
+		'array_rand' => ['int|string|array<int,int>|array<int,string>', 'input'=>'array', 'num_req'=>'int'],
+		'array_rand\'1' => ['int|string', 'input'=>'array'],
 	],
 ];

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -2331,4 +2331,27 @@ public function testBug13556(): void
 		$this->analyse([__DIR__ . '/data/bug-13556.php'], []);
 	}
 
+	#[RequiresPhp('>= 8.0')]
+	public function testArrayRand(): void
+	{
+		$this->analyse([__DIR__ . '/data/array-rand.php'], [
+			[
+				'Parameter #1 $input of function array_rand expects non-empty-array, array{} given.',
+				7,
+				'array{} is empty.'
+			],
+			[
+				'Parameter #1 $input of function array_rand expects non-empty-array, array{} given.',
+				8,
+				'array{} is empty.'
+			]
+		]);
+	}
+
+	#[RequiresPhp('< 8.0')]
+	public function testArrayRandPhp7(): void
+	{
+		$this->analyse([__DIR__ . '/data/array-rand.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Functions/data/array-rand.php

@@ -0,0 +1,9 @@
+<?php
+
+namespace ArrayRand;
+
+function doFoo(int $i) {
+	$arr = [];
+	$x = array_rand($arr);
+	$y = array_rand($arr, $i);
+}