Add scenario

Author: VincentLanglet

src/Rules/Methods/CallToConstructorStatementWithoutSideEffectsRule.php

@@ -10,6 +10,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Type\NeverType;
+use function count;
 use function sprintf;
 
 /**
@@ -57,6 +58,10 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$constructor = $classReflection->getConstructor();
+		if (count($constructor->getAsserts()->getAsserts()) > 0) {
+			return [];
+		}
+
 		$methodResult = $scope->getType($instantiation);
 		if ($methodResult instanceof NeverType && $methodResult->isExplicit()) {
 			return [];

tests/PHPStan/Rules/Methods/CallToConstructorStatementWithoutSideEffectsRuleTest.php

@@ -51,4 +51,9 @@ public function testBug4455(): void
 		$this->analyse([__DIR__ . '/data/bug-4455-constructor.php'], []);
 	}
 
+	public function testBug12224(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-12224.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Methods/data/bug-12224.php

@@ -29,7 +29,22 @@ public function string(mixed $value): string
 	}
 }
 
+class AssertConstructor
+{
+	/**
+	 * @phpstan-pure
+	 * @phpstan-assert string $value
+	 */
+	public function __construct(mixed $value)
+	{
+		if (!\is_string($value)) {
+			throw new \RuntimeException();
+		}
+	}
+}
+
 /** @var string|null $a */
 $a = '';
 Assert::staticString($a);
 (new Assert())->string($a);
+new AssertConstructor($a);