Fix for BenevolentUnion

Author: VincentLanglet

src/Type/UnionType.php

@@ -676,7 +676,7 @@ public function isScalar(): TrinaryLogic
 
 	public function looseCompare(Type $type, PhpVersion $phpVersion): BooleanType
 	{
-		return $this->unionResults(
+		return $this->notBenevolentUnionResults(
 			static fn (Type $innerType): TrinaryLogic => $innerType->looseCompare($type, $phpVersion)->toTrinaryLogic()
 		)->toBooleanType();
 	}

tests/PHPStan/Rules/Comparison/ConstantLooseComparisonRuleTest.php

@@ -242,4 +242,10 @@ public function testBug8800(): void
 		]);
 	}
 
+	public function testBug13098(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-13098.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Comparison/data/bug-13098.php

@@ -0,0 +1,15 @@
+<?php
+
+namespace Bug13098;
+
+$x = substr($_GET["x"], 0, 10);
+if ($x == "") echo "empty";
+
+$x = get_include_path();
+if ($x == "") echo "empty";
+
+$x = password_hash("password", PASSWORD_DEFAULT);
+if ($x == false) echo "false";
+
+$x = php_sapi_name();
+if ($x == false) echo "false";