Fix HasOffsetValueType::searchArray

Author: VincentLanglet

src/Type/Accessory/HasOffsetValueType.php

@@ -14,11 +14,14 @@
 use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\ConstantScalarType;
 use PHPStan\Type\ErrorType;
+use PHPStan\Type\GeneralizePrecision;
 use PHPStan\Type\IntegerRangeType;
+use PHPStan\Type\IntegerType;
 use PHPStan\Type\IntersectionType;
 use PHPStan\Type\IsSuperTypeOfResult;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\ObjectWithoutClassType;
+use PHPStan\Type\StringType;
 use PHPStan\Type\Traits\MaybeArrayTypeTrait;
 use PHPStan\Type\Traits\MaybeCallableTypeTrait;
 use PHPStan\Type\Traits\MaybeIterableTypeTrait;
@@ -266,7 +269,10 @@ public function searchArray(Type $needleType): Type
 			$needleType instanceof ConstantScalarType && $this->valueType instanceof ConstantScalarType
 			&& $needleType->getValue() === $this->valueType->getValue()
 		) {
-			return $this->offsetType;
+			return new UnionType([
+				new IntegerType(),
+				new StringType(),
+			]);
 		}
 
 		return new MixedType();

tests/PHPStan/Analyser/nsrt/array-search.php

@@ -29,7 +29,7 @@ public function normalArrays(array $arr, string $string): void
 		}
 
 		if (array_key_exists(17, $arr) && $arr[17] === 'foo') {
-			assertType('17', array_search('foo', $arr, true));
+			assertType('int', array_search('foo', $arr, true));
 			assertType('int|false', array_search('foo', $arr));
 			assertType('int|false', array_search($string, $arr, true));
 		}