Check new static() arguments when paired with @phpstan-consistent-constructor

Author: ondrejmirtes

src/Rules/Classes/InstantiationRule.php

@@ -94,6 +94,7 @@ private function checkClassName(string $class, bool $isName, Node $node, Scope $
 					&& $constructor instanceof PhpMethodReflection
 					&& !$constructor->isFinal()->yes()
 					&& !$constructor->getPrototype()->isAbstract()
+					&& !$constructor->getDeclaringClass()->hasConsistentConstructor()
 				) {
 					return [];
 				}

tests/PHPStan/Rules/Classes/InstantiationRuleTest.php

@@ -562,4 +562,14 @@ public function testNamedArgumentsPhpversion(): void
 		$this->analyse([__DIR__ . '/data/named-arguments-phpversion.php'], []);
 	}
 
+	public function testNewStaticWithConsistentConstructor(): void
+	{
+		$this->analyse([__DIR__ . '/data/instantiation-new-static-consistent-constructor.php'], [
+			[
+				'Parameter #1 $i of class InstantiationNewStaticConsistentConstructor\Foo constructor expects int, string given.',
+				18,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Classes/data/instantiation-new-static-consistent-constructor.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace InstantiationNewStaticConsistentConstructor;
+
+/**
+ * @phpstan-consistent-constructor
+ */
+class Foo
+{
+
+	public function __construct(int $i)
+	{
+
+	}
+
+	public function doFoo(): void
+	{
+		$a = new static('s');
+	}
+
+}