Check if @Final property is overridden

Author: lpd-au

src/Rules/Properties/OverridingPropertyRule.php

@@ -145,6 +145,16 @@ public function processNode(Node $node, Scope $scope): array
 			))->identifier('property.parentPropertyFinal')
 				->nonIgnorable()
 				->build();
+		} elseif ($prototype->isFinal()) {
+			$errors[] = RuleErrorBuilder::message(sprintf(
+				'Property %s::$%s overrides @final property %s::$%s.',
+				$classReflection->getDisplayName(),
+				$node->getName(),
+				$prototype->getDeclaringClass()->getDisplayName(),
+				$node->getName(),
+			))->identifier('property.parentPropertyAnnotatedFinal')
+				->nonIgnorable()
+				->build();
 		}
 
 		$typeErrors = [];

tests/PHPStan/Rules/Properties/OverridingPropertyRuleTest.php

@@ -187,19 +187,27 @@ public function testFinal(): void
 		$this->analyse([__DIR__ . '/data/overriding-final-property.php'], [
 			[
 				'Property OverridingFinalProperty\Bar::$a overrides final property OverridingFinalProperty\Foo::$a.',
-				21,
+				27,
 			],
 			[
 				'Property OverridingFinalProperty\Bar::$b overrides final property OverridingFinalProperty\Foo::$b.',
-				23,
+				29,
 			],
 			[
 				'Property OverridingFinalProperty\Bar::$c overrides final property OverridingFinalProperty\Foo::$c.',
-				25,
+				31,
 			],
 			[
 				'Property OverridingFinalProperty\Bar::$d overrides final property OverridingFinalProperty\Foo::$d.',
-				27,
+				33,
+			],
+			[
+				'Property OverridingFinalProperty\Bar::$e overrides @final property OverridingFinalProperty\Foo::$e.',
+				35,
+			],
+			[
+				'Property OverridingFinalProperty\Bar::$f overrides @final property OverridingFinalProperty\Foo::$f.',
+				37,
 			],
 		]);
 	}

tests/PHPStan/Rules/Properties/data/overriding-final-property.php

@@ -13,6 +13,12 @@ class Foo
 
 	protected private(set) int $d;
 
+	/** @final */
+	public $e;
+
+	/** @final */
+	protected $f;
+
 }
 
 class Bar extends Foo
@@ -26,4 +32,8 @@ class Bar extends Foo
 
 	public int $d;
 
+	public $e;
+
+	protected $f;
+
 }