Fix "Crash: str_increment(): Argument #1 ($string) must be composed only of alphanumeric ASCII characters"

Author: staabm

src/Analyser/MutatingScope.php

@@ -139,6 +139,7 @@
 use PHPStan\Type\VoidType;
 use stdClass;
 use Throwable;
+use ValueError;
 use function abs;
 use function array_filter;
 use function array_key_exists;
@@ -1750,7 +1751,11 @@ static function (Node $node, Scope $scope) use ($arrowScope, &$arrowFunctionImpu
 							&& !is_numeric($varValue)
 							&& function_exists('str_increment')
 						) {
-							$varValue = str_increment($varValue);
+							try {
+								$varValue = str_increment($varValue);
+							} catch (ValueError) {
+								return new ErrorType();
+							}
 						} elseif (!is_bool($varValue)) {
 							++$varValue;
 						}

tests/PHPStan/Analyser/nsrt/bug-13481-before-php83.php

@@ -0,0 +1,21 @@
+<?php // lint < 8.3
+
+namespace bug13481BeforePhp83;
+
+use function PHPStan\Testing\assertType;
+
+function bug13481() {
+	$s = 'ab c1';
+	assertType("'ab c2'", str_increment($s));
+
+	++$s;
+	assertType("'ab c2'", $s);
+}
+
+function bug13481b() {
+	$s = '%';
+	assertType("'%'", str_increment($s));
+
+	++$s;
+	assertType("'%'", $s);
+}

tests/PHPStan/Analyser/nsrt/bug-13481-php83.php

@@ -0,0 +1,23 @@
+<?php // lint >= 8.3
+
+namespace bug13481Php83;
+
+use function PHPStan\Testing\assertType;
+use function str_increment;
+
+function bug13481() {
+	$s = 'ab c1';
+	assertType("*ERROR*", str_increment($s));
+
+	++$s;
+	assertType("*ERROR*", $s);
+}
+
+function bug13481b() {
+	$s = '%';
+	assertType("*ERROR*", str_increment($s));
+
+	++$s;
+	assertType("*ERROR*", $s);
+}
+