Make error message more descriptive

Author: Bellangelo

src/Rules/Keywords/RequireFileExistsRule.php

@@ -43,12 +43,7 @@ public function processNode(Node $node, Scope $scope): array
 			$filePath = $this->resolveFilePath($node->expr, $scope);
 			if (is_string($filePath) && !is_file($filePath)) {
 				return [
-					RuleErrorBuilder::message(
-						sprintf(
-							'Required file "%s" does not exist.',
-							$filePath,
-						),
-					)->build(),
+					$this->getErrorMessage($node, $filePath)->build()
 				];
 			}
 		}
@@ -64,6 +59,21 @@ private function shouldProcessNode(Node $node): bool
 			);
 	}
 
+	private function getErrorMessage(Include_ $node, string $filePath): RuleErrorBuilder
+	{
+		$message = match ($node->type) {
+			Include_::TYPE_REQUIRE => 'Path in require() "%s" is not a file or it does not exist.',
+			Include_::TYPE_REQUIRE_ONCE => 'Path in require_once() "%s" is not a file or it does not exist.',
+		};
+
+		return RuleErrorBuilder::message(
+			sprintf(
+				$message,
+				$filePath,
+			),
+		);
+	}
+
 	private function resolveFilePath(Node $node, Scope $scope): ?string
 	{
 		if ($node instanceof String_) {

tests/PHPStan/Rules/Keywords/RequireFileExistsRuleTest.php

@@ -26,11 +26,11 @@ public function testFileExistsButPathIsRelative(): void
 	{
 		$this->analyse([__DIR__ . '/data/file-exists-but-path-is-relative.php'], [
 			[
-				'Required file "include-me-to-prove-you-work.txt" does not exist.',
+				'Path in require() "include-me-to-prove-you-work.txt" is not a file or it does not exist.',
 				5,
 			],
 			[
-				'Required file "include-me-to-prove-you-work.txt" does not exist.',
+				'Path in require_once() "include-me-to-prove-you-work.txt" is not a file or it does not exist.',
 				6,
 			],
 		]);
@@ -45,11 +45,11 @@ public function testFileDoesNotExistUsingClassConst(): void
 	{
 		$this->analyse([__DIR__ . '/data/file-does-not-exist-using-class-const.php'], [
 			[
-				'Required file "a-file-that-does-not-exist.php" does not exist.',
+				'Path in require() "a-file-that-does-not-exist.php" is not a file or it does not exist.',
 				7,
 			],
 			[
-				'Required file "a-file-that-does-not-exist.php" does not exist.',
+				'Path in require_once() "a-file-that-does-not-exist.php" is not a file or it does not exist.',
 				8,
 			],
 		]);
@@ -64,15 +64,15 @@ public function testFileExistsUsingConst(): void
 
 	public function testFileDoesNotExistUsingConst(): void
 	{
-		define('FILE_DOES_NOT_EXIST', 'a-file-that-does-not-exist.txt');
+		define('FILE_DOES_NOT_EXIST', 'a-file-that-does-not-exist.php');
 
 		$this->analyse([__DIR__ . '/data/file-does-not-exist-using-constant.php'], [
 			[
-				'Required file "a-file-that-does-not-exist.txt" does not exist.',
+				'Path in require() "a-file-that-does-not-exist.php" is not a file or it does not exist.',
 				7,
 			],
 			[
-				'Required file "a-file-that-does-not-exist.txt" does not exist.',
+				'Path in require_once() "a-file-that-does-not-exist.php" is not a file or it does not exist.',
 				8,
 			],
 		]);