[BE] Check that each trait is used and analysed at least once

Author: ondrejmirtes

changelog-2.0.md

@@ -14,6 +14,7 @@ Major new features 🚀
     * [Learn more on phpstan.org](https://phpstan.org/blog/enhancements-in-handling-parameters-passed-by-reference)
     * [#2941](https://github.com/phpstan/phpstan-src/pull/2941), thanks @ljmaskey!
 * LogicalXorConstantConditionRule (level 4) (https://github.com/phpstan/phpstan-src/commit/3a12724fd636b1bcf36c22b36e8f765d97150895, https://github.com/phpstan/phpstan-src/commit/3b011f6524254dad0f16840fdcfdbe7421548617), #7539
+* Check that each trait is used and analysed at least once (level 4) (https://github.com/phpstan/phpstan-src/commit/c4d05276fb8605d6ac20acbe1cc5df31cd6c10b0)
 * Check preg_quote delimiter sanity (level 0) ([#3252](https://github.com/phpstan/phpstan-src/pull/3252)), #11338, thanks @staabm!
 * Added previously absent type checks (level 0)
   * Check existing classes in `@phpstan-self-out` (https://github.com/phpstan/phpstan-src/commit/6838669976bf20232abde36ecdd52b1770fa50c9)
@@ -44,7 +45,6 @@ Bleeding edge (TODO move to other sections)
 * Unresolvable parameters ([#1319](https://github.com/phpstan/phpstan-src/pull/1319)), thanks @rvanvelzen!
 * Support `@readonly` property and `@immutable` class PHPDoc ([#1295](https://github.com/phpstan/phpstan-src/pull/1295), [#1335](https://github.com/phpstan/phpstan-src/pull/1335)), #4082, thanks @herndlm!
 * Move IllegalConstructorMethodCallRule and IllegalConstructorStaticCallRule to phpstan-strict-rules (https://github.com/phpstan/phpstan-src/commit/124b30f98c182193187be0b9c2e151e477429b7a, https://github.com/phpstan/phpstan-strict-rules/commit/0c82c96f2a55d8b91bbc7ee6512c94f68a206b43)
-* Check that each trait is used and analysed at least once - level 4 (https://github.com/phpstan/phpstan-src/commit/c4d05276fb8605d6ac20acbe1cc5df31cd6c10b0)
 * Check that PHPStan class in class constant fetch is covered by backward compatibility promise (https://github.com/phpstan/phpstan-src/commit/9e007251ce61788f6a0319a53f1de6cf801ed233)
 * Check code in custom PHPStan extensions for runtime reflection concepts like `is_a()` or `class_parents()` (https://github.com/phpstan/phpstan-src/commit/c4a662ac6c3ec63f063238880b243b5399c34fcc)
 * Check code in custom PHPStan extensions for runtime reflection concepts like `new ReflectionMethod()` (https://github.com/phpstan/phpstan-src/commit/536306611cbb5877b6565755cd07b87f9ccfdf08)

conf/bleedingEdge.neon

@@ -14,7 +14,6 @@ parameters:
 		checkUnresolvableParameterTypes: true
 		readOnlyByPhpDoc: true
 		runtimeReflectionRules: true
-		notAnalysedTrait: true
 		curlSetOptTypes: true
 		missingMagicSerializationRule: true
 		nullContextForVoidReturningFunctions: true

conf/config.level4.neon

@@ -17,16 +17,11 @@ rules:
 	- PHPStan\Rules\TooWideTypehints\TooWideFunctionReturnTypehintRule
 	- PHPStan\Rules\TooWideTypehints\TooWideFunctionParameterOutTypeRule
 	- PHPStan\Rules\TooWideTypehints\TooWideMethodParameterOutTypeRule
+	- PHPStan\Rules\Traits\NotAnalysedTraitRule
 
 conditionalTags:
 	PHPStan\Rules\Comparison\ConstantLooseComparisonRule:
 		phpstan.rules.rule: %featureToggles.looseComparison%
-	PHPStan\Rules\Traits\TraitDeclarationCollector:
-		phpstan.collector: %featureToggles.notAnalysedTrait%
-	PHPStan\Rules\Traits\TraitUseCollector:
-		phpstan.collector: %featureToggles.notAnalysedTrait%
-	PHPStan\Rules\Traits\NotAnalysedTraitRule:
-		phpstan.rules.rule: %featureToggles.notAnalysedTrait%
 	PHPStan\Rules\DeadCode\CallToConstructorStatementWithoutImpurePointsRule:
 		phpstan.rules.rule: %featureToggles.pure%
 	PHPStan\Rules\DeadCode\PossiblyPureNewCollector:
@@ -299,12 +294,13 @@ services:
 
 	-
 		class: PHPStan\Rules\Traits\TraitDeclarationCollector
+		tags:
+			- phpstan.collector
 
 	-
 		class: PHPStan\Rules\Traits\TraitUseCollector
-
-	-
-		class: PHPStan\Rules\Traits\NotAnalysedTraitRule
+		tags:
+			- phpstan.collector
 
 	-
 		class: PHPStan\Rules\Exceptions\CatchWithUnthrownExceptionRule

conf/config.neon

@@ -35,7 +35,6 @@ parameters:
 		checkUnresolvableParameterTypes: false
 		readOnlyByPhpDoc: false
 		runtimeReflectionRules: false
-		notAnalysedTrait: false
 		curlSetOptTypes: false
 		missingMagicSerializationRule: false
 		nullContextForVoidReturningFunctions: false

conf/parametersSchema.neon

@@ -41,7 +41,6 @@ parametersSchema:
 		checkUnresolvableParameterTypes: bool()
 		readOnlyByPhpDoc: bool()
 		runtimeReflectionRules: bool()
-		notAnalysedTrait: bool()
 		curlSetOptTypes: bool()
 		missingMagicSerializationRule: bool()
 		nullContextForVoidReturningFunctions: bool()