Handle include() and include_once()

Author: Bellangelo

src/Rules/Keywords/RequireFileExistsRule.php

@@ -26,26 +26,16 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		if ($this->shouldProcessNode($node)) {
-			$filePath = $this->resolveFilePath($node, $scope);
-			if (is_string($filePath) && !is_file($filePath)) {
-				return [
-					$this->getErrorMessage($node, $filePath),
-				];
-			}
+		$filePath = $this->resolveFilePath($node, $scope);
+		if (is_string($filePath) && !is_file($filePath)) {
+			return [
+				$this->getErrorMessage($node, $filePath),
+			];
 		}
 
 		return [];
 	}
 
-	private function shouldProcessNode(Node $node): bool
-	{
-		return $node instanceof Include_ && (
-				$node->type === Include_::TYPE_REQUIRE
-				|| $node->type === Include_::TYPE_REQUIRE_ONCE
-			);
-	}
-
 	private function getErrorMessage(Include_ $node, string $filePath): RuleError
 	{
 		switch ($node->type) {
@@ -55,6 +45,12 @@ private function getErrorMessage(Include_ $node, string $filePath): RuleError
 			case Include_::TYPE_REQUIRE_ONCE:
 				$message = 'Path in require_once() "%s" is not a file or it does not exist.';
 				break;
+			case Include_::TYPE_INCLUDE:
+				$message = 'Path in include() "%s" is not a file or it does not exist.';
+				break;
+			case Include_::TYPE_INCLUDE_ONCE:
+				$message = 'Path in include_once() "%s" is not a file or it does not exist.';
+				break;
 			default:
 				throw new ShouldNotHappenException('Rule should have already validated the node type.');
 		}

tests/PHPStan/Rules/Keywords/RequireFileExistsRuleTest.php

@@ -25,6 +25,14 @@ public function testItCannotReadConstantsDefinedInTheAnalysedFile(): void
 	public function testFileExistsButPathIsRelative(): void
 	{
 		$this->analyse([__DIR__ . '/data/file-exists-but-path-is-relative.php'], [
+			[
+				'Path in include() "include-me-to-prove-you-work.txt" is not a file or it does not exist.',
+				3,
+			],
+			[
+				'Path in include_once() "include-me-to-prove-you-work.txt" is not a file or it does not exist.',
+				4,
+			],
 			[
 				'Path in require() "include-me-to-prove-you-work.txt" is not a file or it does not exist.',
 				5,
@@ -44,6 +52,14 @@ public function testFileExistsUsingClassConst(): void
 	public function testFileDoesNotExistUsingClassConst(): void
 	{
 		$this->analyse([__DIR__ . '/data/file-does-not-exist-using-class-const.php'], [
+			[
+				'Path in include() "a-file-that-does-not-exist.php" is not a file or it does not exist.',
+				5,
+			],
+			[
+				'Path in include_once() "a-file-that-does-not-exist.php" is not a file or it does not exist.',
+				6,
+			],
 			[
 				'Path in require() "a-file-that-does-not-exist.php" is not a file or it does not exist.',
 				7,
@@ -67,6 +83,14 @@ public function testFileDoesNotExistUsingConst(): void
 		define('FILE_DOES_NOT_EXIST', 'a-file-that-does-not-exist.php');
 
 		$this->analyse([__DIR__ . '/data/file-does-not-exist-using-constant.php'], [
+			[
+				'Path in include() "a-file-that-does-not-exist.php" is not a file or it does not exist.',
+				5,
+			],
+			[
+				'Path in include_once() "a-file-that-does-not-exist.php" is not a file or it does not exist.',
+				6,
+			],
 			[
 				'Path in require() "a-file-that-does-not-exist.php" is not a file or it does not exist.',
 				7,
@@ -91,6 +115,14 @@ public function testFileExistsUsingVariables(): void
 	public function testFileDoesNotExistButUsesVariables(): void
 	{
 		$this->analyse([__DIR__ . '/data/file-does-not-exist-but-uses-a-variable.php'], [
+			[
+				'Path in include() "a-file-that-does-not-exist.php" is not a file or it does not exist.',
+				5,
+			],
+			[
+				'Path in include_once() "a-file-that-does-not-exist.php" is not a file or it does not exist.',
+				6,
+			],
 			[
 				'Path in require() "a-file-that-does-not-exist.php" is not a file or it does not exist.',
 				7,