Fix

Co-authored-by: Vincent Langlet <[email protected]>

Author: zonuexe

src/Rules/Comparison/ConstantLooseComparisonRule.php

@@ -8,7 +8,6 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Type\VerbosityLevel;
-use function in_array;
 use function sprintf;
 
 /**
@@ -57,7 +56,7 @@ public function processNode(Node $node, Scope $scope): array
 			return $ruleErrorBuilder->treatPhpDocTypesAsCertainTip();
 		};
 
-		if (in_array(false, $nodeType->getConstantScalarValues(), true)) {
+		if ($nodeType->isFalse()->yes()) {
 			return [
 				$addTip(RuleErrorBuilder::message(sprintf(
 					'Loose comparison using %s between %s and %s will always evaluate to false.',

src/Rules/Comparison/ImpossibleCheckTypeHelper.php

@@ -35,7 +35,6 @@
 use function count;
 use function implode;
 use function in_array;
-use function is_bool;
 use function is_string;
 use function sprintf;
 use function strtolower;
@@ -69,12 +68,13 @@ public function findSpecifiedType(
 				$functionName = strtolower((string) $node->name);
 				if ($functionName === 'assert' && $argsCount >= 1) {
 					$arg = $node->getArgs()[0]->value;
-					$assertValues = ($this->treatPhpDocTypesAsCertain ? $scope->getType($arg) : $scope->getNativeType($arg))->getConstantScalarValues();
-					if (count($assertValues) !== 1 || !is_bool($assertValues[0])) {
+					$assertValue = ($this->treatPhpDocTypesAsCertain ? $scope->getType($arg) : $scope->getNativeType($arg))->toBoolean();
+					if (! $assertValue->isTrue()->yes() && ! $assertValue->isFalse()->yes()) {
 						return null;
 					}
 
-					return $assertValues[0];
+					/** @var bool */
+					return $assertValue->getConstantScalarValues()[0];
 				}
 				if (in_array($functionName, [
 					'class_exists',