Scope::getNativeType() also cannot be called in PHPStan\Analyser\Generator namespace

Author: ondrejmirtes

build/PHPStan/Build/ScopeGetTypeInGeneratorNamespaceRule.php

@@ -7,8 +7,10 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
+use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\ObjectType;
 use PHPUnit\Framework\TestCase;
+use function in_array;
 use function sprintf;
 use function str_starts_with;
 
@@ -39,7 +41,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		if ($node->name->toLowerString() !== 'gettype') {
+		if (!in_array($node->name->toLowerString(), ['gettype', 'getnativetype'], true)) {
 			return [];
 		}
 
@@ -56,9 +58,15 @@ public function processNode(Node $node, Scope $scope): array
 			}
 		}
 
+		$methodReflection = $scope->getMethodReflection($calledOnType, $node->name->toString());
+		if ($methodReflection === null) {
+			throw new ShouldNotHappenException();
+		}
+
 		return [
 			RuleErrorBuilder::message(sprintf(
-				'Scope::getType() cannot be called in %s namespace.',
+				'Scope::%s() cannot be called in %s namespace.',
+				$methodReflection->getName(),
 				$invalidNamespace,
 			))
 				->identifier('phpstan.scopeGetType')

tests/PHPStan/Build/ScopeGetTypeInGeneratorNamespaceRuleTest.php

@@ -34,6 +34,11 @@ public function testRule(): void
 				48,
 				'Use new ExprAnalysisRequest instead.',
 			],
+			[
+				'Scope::getNativeType() cannot be called in PHPStan\Analyser\Generator namespace.',
+				49,
+				'Use new ExprAnalysisRequest instead.',
+			],
 		]);
 	}
 

tests/PHPStan/Build/data/scope-get-type-generator-ns.php

@@ -46,6 +46,7 @@ public function doFoo(Scope $scope): void
 		public function doBar(GeneratorScope $scope): void
 		{
 			$scope->getType();
+			$scope->getNativeType();
 		}
 
 	}