ImpossibleInstanceofRule - test a tricky situation

Author: ondrejmirtes

tests/PHPStan/Rules/Classes/ImpossibleInstanceOfRuleTest.php

@@ -532,6 +532,10 @@ public function testNewIsAlwaysFinalClass(): void
 				'Instanceof between ImpossibleInstanceofNewIsAlwaysFinal\Bar and ImpossibleInstanceofNewIsAlwaysFinal\Foo will always evaluate to false.',
 				63,
 			],
+			[
+				'Instanceof between ImpossibleInstanceofNewIsAlwaysFinal\Bar|null and ImpossibleInstanceofNewIsAlwaysFinal\Foo will always evaluate to false.',
+				73,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Classes/data/impossible-instanceof-new-is-always-final.php

@@ -64,3 +64,13 @@ function (Bar $bar): void {
 
 	}
 };
+
+function (): void {
+	$bar = null;
+	if (rand(0,1)===1) {
+		$bar = new Bar();
+	}
+	if ($bar instanceof Foo) {
+
+	}
+};