Consider assert as side effect

Author: VincentLanglet

src/Rules/Functions/CallToFunctionStatementWithoutSideEffectsRule.php

@@ -11,6 +11,7 @@
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Type\NeverType;
 use PHPStan\Type\Type;
+use function count;
 use function in_array;
 use function sprintf;
 
@@ -65,6 +66,10 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$function = $this->reflectionProvider->getFunction($funcCall->name, $scope);
+		if (count($function->getAsserts()->getAsserts()) > 0) {
+			return [];
+		}
+
 		$functionName = $function->getName();
 		$functionHasSideEffects = !$function->hasSideEffects()->no();
 

src/Rules/Methods/CallToConstructorStatementWithoutSideEffectsRule.php

@@ -10,6 +10,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Type\NeverType;
+use function count;
 use function sprintf;
 
 /**
@@ -57,6 +58,10 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$constructor = $classReflection->getConstructor();
+		if (count($constructor->getAsserts()->getAsserts()) > 0) {
+			return [];
+		}
+
 		$methodResult = $scope->getType($instantiation);
 		if ($methodResult instanceof NeverType && $methodResult->isExplicit()) {
 			return [];

src/Rules/Methods/CallToMethodStatementWithoutSideEffectsRule.php

@@ -13,6 +13,7 @@
 use PHPStan\Type\ErrorType;
 use PHPStan\Type\NeverType;
 use PHPStan\Type\Type;
+use function count;
 use function sprintf;
 
 /**
@@ -69,6 +70,9 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$method = $calledOnType->getMethod($methodName, $scope);
+		if (count($method->getAsserts()->getAsserts()) > 0) {
+			return [];
+		}
 
 		return [
 			RuleErrorBuilder::message(sprintf(

src/Rules/Methods/CallToStaticMethodStatementWithoutSideEffectsRule.php

@@ -15,6 +15,7 @@
 use PHPStan\Type\NeverType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
+use function count;
 use function sprintf;
 use function strtolower;
 
@@ -87,6 +88,10 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
+		if (count($method->getAsserts()->getAsserts()) > 0) {
+			return [];
+		}
+
 		$methodResult = $scope->getType($staticCall);
 		if ($methodResult instanceof NeverType && $methodResult->isExplicit()) {
 			return [];

tests/PHPStan/Rules/Functions/CallToFunctionStatementWithoutSideEffectsRuleTest.php

@@ -85,6 +85,11 @@ public function testPhpDoc(): void
 		]);
 	}
 
+	public function testBug12224(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-12224.php'], []);
+	}
+
 	public function testBug4455(): void
 	{
 		require_once __DIR__ . '/data/bug-4455.php';

tests/PHPStan/Rules/Functions/data/bug-12224.php

@@ -0,0 +1,19 @@
+<?php declare(strict_types = 1);
+
+namespace Bug12224Function;
+
+/**
+ * @phpstan-pure
+ * @phpstan-assert string $value
+ */
+function string(mixed $value): string
+{
+	if (\is_string($value)) {
+		return $value;
+	}
+	throw new \RuntimeException();
+}
+
+/** @var string|null $a */
+$a = '';
+string($a);

tests/PHPStan/Rules/Methods/CallToConstructorStatementWithoutSideEffectsRuleTest.php

@@ -51,4 +51,9 @@ public function testBug4455(): void
 		$this->analyse([__DIR__ . '/data/bug-4455-constructor.php'], []);
 	}
 
+	public function testBug12224(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-12224.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Methods/CallToMethodStatementWithoutSideEffectsRuleTest.php

@@ -136,6 +136,11 @@ public function testBug11503(): void
 		$this->analyse([__DIR__ . '/data/bug-11503.php'], $errors);
 	}
 
+	public function testBug12224(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-12224.php'], []);
+	}
+
 	public function testFirstClassCallables(): void
 	{
 		$this->analyse([__DIR__ . '/data/first-class-callable-method-without-side-effect.php'], [

tests/PHPStan/Rules/Methods/CallToStaticMethodStatementWithoutSideEffectsRuleTest.php

@@ -84,6 +84,11 @@ public function testBug4455(): void
 		$this->analyse([__DIR__ . '/data/bug-4455-static.php'], []);
 	}
 
+	public function testBug12224(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-12224.php'], []);
+	}
+
 	public function testFirstClassCallables(): void
 	{
 		$this->analyse([__DIR__ . '/data/first-class-callable-static-method-without-side-effect.php'], [

tests/PHPStan/Rules/Methods/data/bug-12224.php

@@ -0,0 +1,50 @@
+<?php declare(strict_types = 1);
+
+namespace Bug12224Method;
+
+class Assert
+{
+	/**
+	 * @phpstan-pure
+	 * @phpstan-assert string $value
+	 */
+	public static function staticString(mixed $value): string
+	{
+		if (\is_string($value)) {
+			return $value;
+		}
+		throw new \RuntimeException();
+	}
+
+	/**
+	 * @phpstan-pure
+	 * @phpstan-assert string $value
+	 */
+	public function string(mixed $value): string
+	{
+		if (\is_string($value)) {
+			return $value;
+		}
+		throw new \RuntimeException();
+	}
+}
+
+class AssertConstructor
+{
+	/**
+	 * @phpstan-pure
+	 * @phpstan-assert string $value
+	 */
+	public function __construct(mixed $value)
+	{
+		if (!\is_string($value)) {
+			throw new \RuntimeException();
+		}
+	}
+}
+
+/** @var string|null $a */
+$a = '';
+Assert::staticString($a);
+(new Assert())->string($a);
+new AssertConstructor($a);