Avoid calling methods twice with variables

Co-authored-by: Markus Staab <[email protected]>

Author: zonuexe

src/Rules/Arrays/DuplicateKeysInLiteralArraysRule.php

@@ -78,12 +78,13 @@ public function processNode(Node $node, Scope $scope): array
 				}
 			}
 
-			if (count($keyType->getConstantScalarValues()) === 0) {
+			$keyValues = $keyType->getConstantScalarValues();
+			if (count($keyValues) === 0) {
 				$autoGeneratedIndex = false;
 				continue;
 			}
 
-			foreach ($keyType->getConstantScalarValues() as $value) {
+			foreach ($keyValues as $value) {
 				$printedValue = $key !== null
 					? $this->exprPrinter->printExpr($key)
 					: $value;

src/Rules/PhpDoc/RequireExtendsCheck.php

@@ -43,14 +43,14 @@ public function checkExtendsTags(Node $node, array $extendsTags): array
 
 		foreach ($extendsTags as $extendsTag) {
 			$type = $extendsTag->getType();
-			if (count($type->getObjectClassNames()) === 0) {
+			$classNames = $type->getObjectClassNames();
+			if (count($classNames) === 0) {
 				$errors[] = RuleErrorBuilder::message(sprintf('PHPDoc tag @phpstan-require-extends contains non-object type %s.', $type->describe(VerbosityLevel::typeOnly())))
 					->identifier('requireExtends.nonObject')
 					->build();
 				continue;
 			}
 
-			$classNames = $type->getObjectClassNames();
 			sort($classNames);
 			$referencedClassReflections = array_map(static fn ($reflection) => [$reflection, $reflection->getName()], $type->getObjectClassReflections());
 			$referencedClassReflectionsMap = array_column($referencedClassReflections, 0, 1);

src/Rules/PhpDoc/RequireImplementsDefinitionTraitRule.php

@@ -51,7 +51,8 @@ public function processNode(Node $node, Scope $scope): array
 		$errors = [];
 		foreach ($implementsTags as $implementsTag) {
 			$type = $implementsTag->getType();
-			if (count($type->getObjectClassNames()) === 0) {
+			$classNames = $type->getObjectClassNames();
+			if (count($classNames) === 0) {
 				$errors[] = RuleErrorBuilder::message(sprintf('PHPDoc tag @phpstan-require-implements contains non-object type %s.', $type->describe(VerbosityLevel::typeOnly())))
 					->identifier('requireImplements.nonObject')
 					->build();
@@ -60,7 +61,7 @@ public function processNode(Node $node, Scope $scope): array
 
 			$referencedClassReflections = array_map(static fn ($reflection) => [$reflection, $reflection->getName()], $type->getObjectClassReflections());
 			$referencedClassReflectionsMap = array_column($referencedClassReflections, 0, 1);
-			foreach ($type->getObjectClassNames() as $class) {
+			foreach ($classNames as $class) {
 				$referencedClassReflection = $referencedClassReflectionsMap[$class] ?? null;
 				if ($referencedClassReflection === null) {
 					$errors[] = RuleErrorBuilder::message(sprintf('PHPDoc tag @phpstan-require-implements contains unknown class %s.', $class))

src/Rules/Variables/CompactVariablesRule.php

@@ -70,8 +70,9 @@ public function processNode(Node $node, Scope $scope): array
 	 */
 	private function findConstantStrings(Type $type): array
 	{
-		if (count($type->getConstantStrings()) > 0) {
-			return $type->getConstantStrings();
+		$constantStrings = $type->getConstantStrings();
+		if (count($constantStrings) > 0) {
+			return $constantStrings;
 		}
 
 		$result = [];