more readable

staabm · staabm · commit 5e5e0b881b11 · 2025-04-13T10:47:07.000+02:00
diff --git a/src/Analyser/MutatingScope.php b/src/Analyser/MutatingScope.php
@@ -4428,7 +4428,7 @@ public function addTypeToExpression(Expr $expr, Type $type): self
 
 		if ($originalExprType->equals($nativeType)) {
 			$newType = TypeCombinator::intersect($type, $originalExprType);
-			if ($newType->isConstantScalarValue()->yes() && $newType->equals($nativeType)) {
+			if ($newType->isConstantScalarValue()->yes() && $newType->equals($originalExprType)) {
 				// don't add the same type over and over again to improve performance
 				return $this;
 			}

Original file line number	Diff line number	Diff line change
`@@ -4428,7 +4428,7 @@ public function addTypeToExpression(Expr $expr, Type $type): self`
`4428`	`4428`
`4429`	`4429`	`if ($originalExprType->equals($nativeType)) {`
`4430`	`4430`	`$newType = TypeCombinator::intersect($type, $originalExprType);`
`4431`		`- if ($newType->isConstantScalarValue()->yes() && $newType->equals($nativeType)) {`
	`4431`	`+ if ($newType->isConstantScalarValue()->yes() && $newType->equals($originalExprType)) {`
`4432`	`4432`	`// don't add the same type over and over again to improve performance`
`4433`	`4433`	`return $this;`
`4434`	`4434`	`}`