Skip to content

Commit 66086e9

Browse files
Fix uopz signature
1 parent ce0aaf2 commit 66086e9

File tree

4 files changed

+32
-4
lines changed

4 files changed

+32
-4
lines changed

resources/functionMap.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12949,8 +12949,8 @@
1294912949
'uopz_get_hook' => ['Closure', 'class'=>'string', 'function'=>'string'],
1295012950
'uopz_get_hook\1' => ['Closure', 'function'=>'string'],
1295112951
'uopz_get_mock' => ['mixed', 'class'=>'string'],
12952-
'uopz_get_property' => ['void', 'class'=>'string', 'property'=>'string'],
12953-
'uopz_get_property\1' => ['void', 'instance'=>'object', 'property'=>'string'],
12952+
'uopz_get_property' => ['mixed', 'class'=>'string', 'property'=>'string'],
12953+
'uopz_get_property\1' => ['mixed', 'instance'=>'object', 'property'=>'string'],
1295412954
'uopz_get_return' => ['mixed', 'class='=>'string', 'function='=>'string'],
1295512955
'uopz_get_static' => ['array', 'class='=>'string', 'function='=>'string'],
1295612956
'uopz_get_static\1' => ['array', 'function='=>'string'],

src/Reflection/SignatureMap/FunctionSignatureMapProvider.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,11 @@ public function getFunctionSignatures(string $functionName, ?string $className,
5858

5959
$signatures = [$this->createSignature($functionName, $className, $reflectionFunction)];
6060
$i = 1;
61-
$variantFunctionName = $functionName . '\'' . $i;
61+
$variantFunctionName = $functionName . '\\' . $i;
6262
while ($this->hasFunctionSignature($variantFunctionName)) {
6363
$signatures[] = $this->createSignature($variantFunctionName, $className, $reflectionFunction);
6464
$i++;
65-
$variantFunctionName = $functionName . '\'' . $i;
65+
$variantFunctionName = $functionName . '\\' . $i;
6666
}
6767

6868
return ['positional' => $signatures, 'named' => null];

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1939,4 +1939,9 @@ public function testBug9167(): void
19391939
$this->analyse([__DIR__ . '/data/bug-9167.php'], []);
19401940
}
19411941

1942+
public function testBug12499(): void
1943+
{
1944+
$this->analyse([__DIR__ . '/data/bug-12499.php'], []);
1945+
}
1946+
19421947
}
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
<?php
2+
3+
namespace Bug12499;
4+
5+
class HelloWorld {
6+
public static string $testString = 'test';
7+
}
8+
9+
$property = uopz_get_property(HelloWorld::class, 'testString');
10+
11+
uopz_set_property(HelloWorld::class, 'testString', 'test2');
12+
13+
class HelloWorld2 {
14+
public function __construct(
15+
public string $testString,
16+
) {}
17+
}
18+
19+
$classInstance = new HelloWorld2('test');
20+
21+
$property = uopz_get_property($classInstance, 'testString');
22+
23+
uopz_set_property($classInstance, 'testString', 'test2');

0 commit comments

Comments
 (0)