ConsistentConstructorDeclarationRule

Author: ondrejmirtes

src/Rules/Methods/ConsistentConstructorDeclarationRule.php

@@ -0,0 +1,50 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Methods;
+
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\RegisteredRule;
+use PHPStan\Node\InClassMethodNode;
+use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleErrorBuilder;
+use function strtolower;
+
+/** @implements Rule<InClassMethodNode> */
+#[RegisteredRule(level: 0)]
+final class ConsistentConstructorDeclarationRule implements Rule
+{
+
+	public function getNodeType(): string
+	{
+		return InClassMethodNode::class;
+	}
+
+	public function processNode(Node $node, Scope $scope): array
+	{
+		$method = $node->getMethodReflection();
+		if (strtolower($method->getName()) !== '__construct') {
+			return [];
+		}
+
+		$classReflection = $node->getClassReflection();
+		if (!$classReflection->hasConsistentConstructor()) {
+			return [];
+		}
+
+		if ($classReflection->isFinal()) {
+			return [];
+		}
+
+		if (!$method->isPrivate()) {
+			return [];
+		}
+
+		return [
+			RuleErrorBuilder::message('Private constructor cannot be enforced as consistent for child classes.')
+				->identifier('consistentConstructor.private')
+				->build(),
+		];
+	}
+
+}

tests/PHPStan/Rules/Methods/ConsistentConstructorDeclarationRuleTest.php

@@ -0,0 +1,29 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Methods;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+
+/**
+ * @extends RuleTestCase<ConsistentConstructorDeclarationRule>
+ */
+class ConsistentConstructorDeclarationRuleTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new ConsistentConstructorDeclarationRule();
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/consistent-constructor-declaration.php'], [
+			[
+				'Private constructor cannot be enforced as consistent for child classes.',
+				31,
+			],
+		]);
+	}
+
+}

tests/PHPStan/Rules/Methods/data/consistent-constructor-declaration.php

@@ -0,0 +1,36 @@
+<?php
+
+namespace ConsistentConstructorDeclaration;
+
+/** @phpstan-consistent-constructor */
+class Foo
+{
+
+	public function __construct()
+	{
+		// not private
+	}
+
+}
+
+/** @phpstan-consistent-constructor */
+final class Bar
+{
+
+	private function __construct()
+	{
+		// private but class final
+	}
+
+}
+
+/** @phpstan-consistent-constructor */
+class Baz
+{
+
+	private function __construct()
+	{
+		// error
+	}
+
+}