prevent crash

Author: staabm

src/Type/Php/ArrayCombineFunctionReturnTypeExtension.php

@@ -20,6 +20,7 @@
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
 use PHPStan\Type\UnionType;
+use function array_key_exists;
 use function count;
 use function is_int;
 use function is_string;
@@ -77,6 +78,10 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 
 				$builder = ConstantArrayTypeBuilder::createEmpty();
 				foreach ($keyTypes as $i => $keyType) {
+					if (!array_key_exists($i, $valueTypes)) {
+						$results = [];
+						break 2;
+					}
 					$valueType = $valueTypes[$i];
 					$builder->setOffsetValueType($keyType, $valueType);
 				}

tests/PHPStan/Analyser/nsrt/array-combine-php8.php

@@ -113,6 +113,19 @@ function withUnionConstArraysDifferentArraysCount(): void
 	assertType("non-empty-array<1|'2'|'3', 'apple'|'avocado'|'banana'|'pear'>", array_combine($a, $b));
 }
 
+function withUnionConstArraysAndInvalidKeys(bool $bool): void
+{
+	if (rand(0, 1)) {
+		$a = [$bool];
+		$b = ['avocado'];
+	} else {
+		$a = ["2", $bool];
+		$b = ['apple', 'banana'];
+	}
+
+	assertType("non-empty-array<''|'1'|'2', 'apple'|'avocado'|'banana'>", array_combine($a, $b));
+}
+
 /**
  * @param non-empty-array<int, 'foo'|'bar'|'baz'> $a
  * @param non-empty-array<int, 'apple'|'avocado'|'banana'> $b